EBMS Tickets

Issue Number 108
Summary [General] Minor Text Changes to Form Instructions
Created 2013-11-07 17:46:05
Issue Type Task
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2013-12-19 09:54:56
Resolution Fixed
Path /home/bkline/backups/jira/oceebms/issue.114759
Description

I'm adding a general task for us to revisit each of the forms and consider adding/revising the text. I don't have specific requirements/changes at this time, but I wanted to capture the issue for a later time.

The forms that we'll want to look at are:

BOARD MEMBER PAGES

  • Review page for an article

  • Reviewer upload page

  • Board Member upload page

  • Hotel Request

  • Reimbursement Request

  • Create new topic

INTERNAL PAGES

  • Post document

  • Print packets

  • Manage print recipients

Comment entered 2013-12-11 14:34:47 by Kline, Bob (NIH/NCI) [C]

We're assuming (for the purposes of the story point estimation) that we'll be given a list of static text changes to be made to each of the pages, and that the text is not dynamically assembled from multiple sources or from computations.

It would be good for the users to prioritize the changes in order to ensure that the most important ones are included.

Comment entered 2013-12-18 18:07:56 by Juthe, Robin (NIH/NCI) [E]

Here are the requested changes (these are listed in order of priority):

Reimbursement Request Page.
1. Please change the instructions beneath each of the "Date of Expense" fields from "Please select the date in which this expense occured." to "Please select the date on which this expense occurred."

Review article page (former "coversheet" for a single article)
1. Please change the instructions for the comments field from "Detailed recommendations" to "Please make your suggested changes directly in the summary using Track Changes. If you have additional comments, please add them here."

Packet page (the page for a single packet)
1. We would like to add the following instructional text beneath the title of the packet: "Click on the summary document to open it on your computer. Review articles. If needed, make changes to the summary using Track Changes and save it to your computer. Then, upload the document with your changes using the Post Document button."

Reviewer Upload page (accessible via the Post Document link from inside a packet)
1. Please add the following instructional text beneath the Choose File box: "Before you can upload a summary with your changes, you must save it to your computer. Click on the Browse button to select the summary you would like to upload. To complete the file upload, you must click the Upload File button."

Board Member Upload page (accessible via the Post Document link on the summaries page)
1. Please add the following instructional text beneath the Choose File box: "Click on the Browse button to select the document you would like to upload. To complete the file upload, you must click the Upload File button."

More to come....but posting this before I lose my comment.

Comment entered 2013-12-18 18:17:54 by Juthe, Robin (NIH/NCI) [E]

Post Document page
1. Please change "DESCRIPTION" to "EBMS NAME". Please add the following instructional text after "EBMS NAME": "This will be the title of the document in the EBMS."

Manage Print Recipients page (also called Edit the Board Members Printing Table)
1. Beneath the table of Board members, please change the first sentence to "To add a board member to the list, select the Board member, enter a start date, and click Submit."
2. Please change the second sentence to "To delete a Board member, select the member's name, check the Delete checkbox, and click Submit."
3. Please remove "(HH:MM:SS OPTIONAL}" in each occurrence.

Print Packets page
1. Please change "PACKET INTERNAL ID" to "PACKET ID".
2. Beneath PACKET ID, please change the first sentence to: "To print a single packet, regardless of board or board member, enter the packet ID."
3. Beneath "ONLY PRINT PACKETS CREATED ON OR AFTER THIS START DATE", please change the instructions to the following: "Optionally, print packets created on or after the specified date, entered as "YYYY-MM-DD". Packets that have already been printed will not be printed again unless an earlier date or a packet ID is specified."
4. Beneath "ONLY PRINT PACKETS CREATED BEFORE THIS END DATE", please remove the "{HH:MM:SS}" from the first line. Please change the second sentence to "The default end date is today."
5. Please change "OLD PRINT JOB ID" to "REPRINT SUCCESSFUL PRINT JOB". Please change the first sentence under this heading to "Optionally, enter the job ID of a print job to be re-run. (See View Packet Print Jobs page)." If possible, please link "View Packet Print Jobs" to the following page: https://ebms.nci.nih.gov/print-packets/view.

Create New Topic page
1. Please remove "(EDIT SUMMARY)" after "BODY" above the box for adding the body of a forum post.

Comment entered 2013-12-19 09:54:56 by Kline, Bob (NIH/NCI) [C]

Changes implemented on DEV. Robin decided not to make the change to the page for adding a new forum topic (she hadn't realized that this change would have removed useful functionality).

  • R12175 modules/custom/ebms_webforms/ebms_webforms.module

  • R12175 modules/custom/ebms/review.inc

  • R12175 modules/custom/ebms/summaries.inc

  • R12175 modules/custom/ebms/docs.inc

  • R12175 modules/custom/ebms/print.inc

Also includes a change which will need to be made by hand, but which can be done without the assistance of CBIIT. Edit the "Transportation" and "Parking and Tolls" components on the reimbursement request form to change the instructions for the "Date of Expense" subfield.

Comment entered 2014-01-05 23:28:02 by Kline, Bob (NIH/NCI) [C]

Note to QA team/testers: Robin agreed that "Click on the Browse button ..." for the Reviewer upload page was not appropriate, because not all browsers label that button "Browse"; instead we decided on "Select the document ...."

Comment entered 2014-01-06 00:47:43 by Kline, Bob (NIH/NCI) [C]

Promoted to QA.

Comment entered 2014-01-16 12:20:35 by Shields, Victoria (NIH/NCI) [E]

On the Packet page (the page for a single packet)
1. to the instructions that have been added below the title of the packet, please add to the last sentence, "...using the Post Document button found in the Reviewer Uploads section below."
2. also on this page, the new text in the Reviewer Uploads section should be removed.
3. on the Post Document page that is linked from this page, the following text should be added, "Select the document you would like to upload. To complete the file upload, you must click the Upload File button below." (This is the same text on the Post Document page that is linked from the Summaries pages.)

On the Create New Topic page
1. can we change "(EDIT SUMMARY)" to just "(EDIT)" without losing any functionality? (Since we usually use "summary" to refer to a PDQ summary, we thought the use here might be confusing to some board members.)

Comment entered 2014-01-17 10:09:32 by Kline, Bob (NIH/NCI) [C]

On the Packet page (the page for a single packet) ...

You mean the reviewer's packet page, right? If so, I think those changes are done. Please check to verify.

On the Create New Topic page ...

I'm guessing you're talking about the Forums section, right? Assuming I'm right, it's unlikely anyone would think a link in the forums section has anything to do with editing a PDQ summary. Changing the link to just "EDIT" would be even more confusing, because that would look like something you'd click to edit the body of the description of the topic (or "thread"), when in fact the link is for specifying the summary of the topic which should appear in the list of all topics for a given forum. If you don't specify this, Drupal will arbitrarily take some amount of text from the beginning of the topic's full description, which isn't always what you want. Even if we wanted to change the label for the link, that wouldn't be trivial, because that's controlled somewhere deep within Drupal, and it's too late in the release cycle to do the investigation to determine whether it's possible to change it (and how to do it).

Comment entered 2014-01-17 11:26:31 by Kline, Bob (NIH/NCI) [C]

The changes I've made are on both DEV and QA.

Comment entered 2014-01-17 13:30:57 by Shields, Victoria (NIH/NCI) [E]

Verified on QA.

Comment entered 2014-02-25 15:46:27 by Juthe, Robin (NIH/NCI) [E]

Verified on prod.

Elapsed: 0:00:00.000759