| Issue Number | 104 |
|---|---|
| Summary | [Full Citation] Full Text Retrieval Comments Do Not Display |
| Created | 2013-11-06 13:47:24 |
| Issue Type | Bug |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2014-01-02 10:45:20 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/oceebms/issue.114659 |
Comments added to the full-text retrieved state are not being saved (or they at least are not displaying) on the full citation page. Bonnie has tried to enter them both when she initially uploads the full-text and by editing the "decision" to upload it again. They also do not appear when the "unable to upload" option is selected.
I'm not observing exactly the behavior you've described. What I see is that when the box is checked on the full citation page to indicate that the full text for the article cannot be retrieved, the comment explaining why the full text is unavailable is stored (and displayed when the full citation page is redrawn). There was no place for storing a comment when the full text was successfully obtained and posted, so Dan didn't try to store the comment in that case. Furthermore, Ashleigh's design for Bonnie's full text retrieval queue didn't have any provision for storing comments for either success or failure (nor did the requirements document).
If I'm wrong about the system storing the comment entered on the full citation page when the box indicating the full text is unavailable, I'll need someone to show me how to reproduce that behavior. If I'm right, I'll need to know if it's sufficient that the comment is being stored and displayed in the case of failure, or if we need to modify the database and the code to store comments when there are no problems retrieving the full text.
The problem I'm seeing is that if Bonnie checks "unable to upload" on the full text retrieval page, and then goes to the full citation to add a comment, she's unable to add a comment because she receives a message indicating that the flag has already been set. (for example, "Unavailable flag already set for article 298388")
So, I think the options are to:
1. Add a comment field on the full-text retrieval page.
2. Remove the unable to upload button from the full-text retrieval page
and only enter this on the full citation page.
3. Allow the same flag to be set again on the full citation page in
order to add a comment.
I'm leaning towards #2 since I don't think Bonnie has many occasion to use the "unable to upload" button. I'd like to run this past her though.
Option #2 would certainly be the easiest to implement.
I discussed this with Bonnie and we agreed to go with #2 (removing the unable to upload button from the full-text retrieval page). Bonnie will go to the full citation page to indicate that she's unable to upload the full-text and add a comment when necessary. She has yet to need this thanks to her master retriever skills!
I have removed the "Unable to Upload" box from the full text retrieval queue page.
R12226 trunk/ebms/ebms.nci.nih.gov/modules/custom/ebms/fulltext.inc
Promoted to QA.
Verified on QA. As noted above, comments are stored when the unable to upload box is checked but they are not stored when the full text article is uploaded.
(In a later iteration, we may want to consider dynamically adding the comment box on the full-citation page when the "unable to upload" option is selected.)
unable to verify until there is an article that requires the 'unable to upload'
Closing issue. We'll re-open it if we have a problem.
Elapsed: 0:00:00.000740