| Issue Number | 106 |
|---|---|
| Summary | [Citation Management] Add "On Hold" as New Value for Literature Surveillance Committee Decision |
| Created | 2013-11-07 15:33:07 |
| Issue Type | Improvement |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2014-08-12 15:20:46 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/oceebms/issue.114743 |
We would like to add a new value for the Lit Surv Committee Decision state: "Hold"
This selection should prevent citations from landing on the "create packet" page but a place for them to collect before we are ready to send them out to Board members for review. A use case for this is when we are collecting literature for a new summary to be written, but we haven't identified a writer yet. We would prefer not to see these citations on the create packet page each month until we are ready to send them to someone to review.
We will likely need to discuss the design implications this will have for the queue page because there isn't currently a lot of real estate for a fourth check box (next to reject, pass, and FYI). We may be able to remove or shorten the wording next to each box. If we remove the wording, we'll need some other visual indicator (colored boxes? yes/no symbols?) of what is involved. This may branch into separate issues, but I figured I would capture some of the considerations in one place for now.
After further discussion, we would like to do the following:
1. Add an "On Hold" value at the literature surveillance committee
decision state. (Please use "On Hold" as opposed to "Hold" for
consistency with the value used at the Board Manager Action
state.)
2. Remove the Board column from the full text queue. This should give us
the needed real estate for the fourth check box.
3. Add an "On Hold review" queue to the queue page for Board managers to
allow us to review and make decisions on articles that have been given
this status. Articles could either be passed or rejected (still at the
literature surveillance committee decision state). This queue would be
accessed by using a check box beneath "Full Text Review" on the queue
page.
Remove the Board column from the full text queue ....
Do you want this for the abstract view as well? Or just for the "brief" view?
This has been implemented on DEV. The code where the change was made (citations.inc) is very complicated, as are the changes made, so I think it would be a very good idea to start looking at this early on, and give it a very thorough shake-down.
I received an error message when I tried to approve a citation in the On Hold queue. See attached screenshot.
I think I have found and fixed the problem. The original code was making assumptions about fields on the page's form based on patterns in the fields' names, so by chance the name of the checkbox for choosing the new queue was mistaken for something it wasn't and the page blew up. As I say, the code in citations.inc is too tricky for its own good. 🙂
Please give it another try.
I'm no longer getting the error (thanks!), but I've run into something else.
Articles that are "approved" from the On Hold queue should appear on the Create Packet page. I just approved a couple of citations in my On Hold queue, but the Create Packets page doesn't have any articles ready to be put into packets.
I believe I have found and fixed the state/packet problem. Can you try again?
This is working. Thanks!
I noticed something else, though. The numbers in parentheses after each summary topic should be updated when you are on the On Hold queue page (as they update when you toggle between the Full-Text and Abstract queue pages). The On Hold queue page is currently showing the citation totals for the full-text queue.
I believe that's working correctly now. Again, we very much appreciate the thorough checking you're doing for this modification. I can't emphasize enough how complex this part of the code is, so every bit of testing is worth its weight in gold! :-)
I verified this latest fix on DEV. Thanks!
Everyone tested this issue and I didn't receive reports of any problems, so I'm considering this verified on DEV.
Needs DB changes in release-3.1-patch.sql.
Verified on QA.
Verified on prod.
It's worth noting that if you put citations for an inactive topic on hold, you must make the topic active in order to see them in your "on hold" queue.
| File Name | Posted | User |
|---|---|---|
| screenshot-1.jpg | 2014-08-13 14:41:25 |
Elapsed: 0:00:00.000723