CDR Tickets

Issue Number 4765
Summary Non-publishable definition text display on Cancer.gov
Created 2020-01-21 18:19:39
Issue Type Bug
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2020-01-22 13:05:17
Resolution Won't Fix
Path /home/bkline/backups/jira/ocecdr/issue.255361
Description

It looks like GTCs with changes that have not been made publishable are displaying on Cancer.gov.
Example:
CDR0000622475[GTC]
CDR0000270741 [GTN]

https://www.cancer.gov/publications/dictionaries/cancer-terms/def/syngeneic-bone-marrow-transplantation

Comment entered 2020-01-21 18:57:05 by Englisch, Volker (NIH/NCI) [C]

The denormalization filter for glossary terms uses the last version of the concept to be included.  Since glossary concepts aren't published on its own we've never required the concept documents to be publishable in order to be included.  At least as far as I remember.

Comment entered 2020-01-21 19:11:24 by Osei-Poku, William (NIH/NCI) [C]

It seems to me that this is a new thing. It appears to be happening after the Kepler release. Is there a way we can find out ?

Comment entered 2020-01-22 10:30:31 by Englisch, Volker (NIH/NCI) [C]

There was a minor change to the filter as part of the kepler release to change adjust the character encoding in the header.  The latest change prior to this was in December 2017 (most likely as part of the streamline efforts).  

In April 2017 the filter was modified to include RelatedGlossaryTerms.

The particular line of code hasn't changed in 12 years according to Git.

Comment entered 2020-01-22 11:00:46 by Juthe, Robin (NIH/NCI) [E]

I seem to remember that the publishability of the GTC document isn't what drives the changes ending up on Cancer.gov. If the GTN is publishable, it will be displayed along with the definition that is in the linked GTC. Since the markup has been accepted in this GTC and versioned, and the GTN was already publishable, I believe that is why these changes were picked up in the last publishing job.

Comment entered 2020-01-22 11:16:44 by Englisch, Volker (NIH/NCI) [C]

That's correct!  A versioned GTC document means "ready to be included"

Comment entered 2020-01-22 13:04:39 by Osei-Poku, William (NIH/NCI) [C]

Thanks and I will close this ticket and we will look into making changes in the future to only allow publishable versions of the GTC just like we do for other documents.

Elapsed: 0:00:00.001730