CDR Tickets

Issue Number 4767
Summary [Summaries] Combined Board Roster Report Displays Former Board Members
Created 2020-01-29 10:03:36
Issue Type Bug
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2020-04-28 09:10:32
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.255835
Description

The combined Board Roster report is displaying both current and past members of the selected Board type (Editorial or Advisory). It doesn't seem to be taking into account the current membership status of the selected Board type in the Board member document.

For example, if you run the report for all Editorial Boards, former members of the Genetics Ed. Board (and current members of the Advisory Board) are displaying on the report, such as Susan Domchek, Kathleen Blazer, Marianne Berwick, and Mark Robson.

If you run the report for all Advisory Boards, Denise Adams, Alan Gamis, and Donald Berry display (they are all former Advisory Board members and current Editorial Board members).

This bug seems to have been introduced by Kepler.

Comment entered 2020-01-29 16:40:52 by Kline, Bob (NIH/NCI) [C]

I think I've got it fixed on DEV. If you confirm that it's working correctly, and you add this to the Leibniz sprint, I'll commit the fix to the leibniz branch.

Comment entered 2020-01-30 08:25:33 by Kline, Bob (NIH/NCI) [C]

Here's the patch.

diff --git a/Inetpub/wwwroot/cgi-bin/cdr/BoardRosterFull.py b/Inetpub/wwwroot/cgi-bin/cdr/BoardRosterFull.py
index 21e89428..900d405f 100644
--- a/Inetpub/wwwroot/cgi-bin/cdr/BoardRosterFull.py
+++ b/Inetpub/wwwroot/cgi-bin/cdr/BoardRosterFull.py
@@ -272,7 +272,8 @@ class Board:
             query = self.control.Query("query_term m", *self.fields).unique()
             query.where(query.Condition("m.path", self.BOARD_PATH))
             query.where(query.Condition("m.int_val", self.id))
-            query.join("query_term c", "c.doc_id = m.doc_id")
+            query.join("query_term c", "c.doc_id = m.doc_id",
+                       "LEFT(c.node_loc, 4) = LEFT(m.node_loc, 4)")
             query.where(query.Condition("c.path", self.CURRENT_PATH))
             query.where("c.value = 'Yes'")
             query.join("query_term p", "p.doc_id = m.doc_id")
Comment entered 2020-01-30 11:57:51 by Juthe, Robin (NIH/NCI) [E]

Thanks, Bob. this looks good on DEV.

Comment entered 2020-04-24 09:48:19 by Juthe, Robin (NIH/NCI) [E]

I'm not sure if this issue has introduced another bug. When I run this report with the following options on DEV, I get an "invalid report format" error message. The sticking point seems to be the last option (Summary Report). The report works on PROD with these selections.

  1. PDQ Editorial Advisory Boards

  2. Group by PDQ Board

  3. Summary report (with default display selections)

Comment entered 2020-04-28 09:10:32 by Kline, Bob (NIH/NCI) [C]

Fixed on DEV.

Comment entered 2020-05-28 14:48:01 by Juthe, Robin (NIH/NCI) [E]

Verified on DEV. Thanks!

Comment entered 2020-07-09 13:03:13 by Juthe, Robin (NIH/NCI) [E]

Verified on PROD.

Elapsed: 0:00:00.000764