CDR Tickets

Issue Number 4764
Summary [Glossary] GTC Full QC report error
Created 2020-01-16 17:53:23
Issue Type Bug
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2020-01-23 07:26:09
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.255256
Description

Some GTC documents are not displaying in the Full QC report. They just display the following error message on PROD:

"int() argument must be a string, a bytes-like object or a number, not 'NoneType' "

It does not happen to every single GTC just some of them.
CDR0000622982
CDR0000622947
CDR0000623070

Comment entered 2020-01-22 12:53:38 by Englisch, Volker (NIH/NCI) [C]

This appears to be a bug introduced by the kepler release.  

The program fails when it's trying to extract the non-existing CDR-ID to display on the report (GlossaryConceptFull.py).

Comment entered 2020-01-22 20:14:52 by Kline, Bob (NIH/NCI) [C]

The problem is that the report is trying to follow RelatedSummaryRef links by using the cdr:href attribute (which doesn't exist, and never has, as far back as I combed through the versions of the schema, going back to before the transition to CBIIT hosting, early in the previous decade) instead of the cdr:ref attribute. The program has been making this mistake since long before Kepler (at least as far back as July 2013, which is as far back as we have tagged versions of the code in GitHub; I could possibly dig further back, but I don't see that it would be worth the trouble).

Here's a patch, which I have checked into the leibniz branch and installed and tested on DEV.

diff --git a/Inetpub/wwwroot/cgi-bin/cdr/GlossaryConceptFull.py b/Inetpub/wwwroot/cgi-bin/cdr/GlossaryConceptFull.py
index af9c21b8..ba88fcee 100644
--- a/Inetpub/wwwroot/cgi-bin/cdr/GlossaryConceptFull.py
+++ b/Inetpub/wwwroot/cgi-bin/cdr/GlossaryConceptFull.py
@@ -617,7 +617,7 @@ class Concept:
         TYPES = dict(
             drug=(DRUG_SUMMARY_LINK, "Rel Drug Summary Link", "ref", True),
             xref=(EXTERNAL_REF, "Rel External Ref", "xref", True),
-            sref=(SUMMARY_REF, "Rel Summary Ref", "href", True),
+            sref=(SUMMARY_REF, "Rel Summary Ref", "ref", True),
             term=(TERM_NAME_LINK, "Rel Glossary Term", "ref", True),
             pdqt=(PDQ_TERM, "PDQ Term", "ref", False),
         )
Comment entered 2020-04-29 09:33:57 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV. Thanks!

Comment entered 2020-06-09 13:43:32 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA. Thanks!

Comment entered 2020-07-15 09:20:59 by Kline, Bob (NIH/NCI) [C]

Still testing?

Attachments
File Name Posted User
GTC Full QC Report Error.PNG 2020-01-16 17:52:43 Osei-Poku, William (NIH/NCI) [C]

Elapsed: 0:00:00.001315