CDR Tickets

We recently modified our QC filters to allow video display for DIS.  I am wondering if we broke the videos for summaries with that filter change.  I'm assuming this problem is a very recent issue but I can't find anything recently updated on PROD that would account for the videos not displaying.

I do see that the "template name" (Video75NoTitle) is being displayed below the caption.  This is certainly wrong and most likely a new issue as well.

Never mind my previous comment.  The changes to the DIS QC report have been copied to STAGE but did not land on PROD yet, so this filter change can't account for the problem.

I am not certain when the display of videos on the QC reports broke.  My best guess at the moment is that the modification to the Glossary Term QC reports, when we included the display of videos broke the video display for summaries.

The following filter has been updated on DEV:

• CDR339576: Module: InLine Markup Formatter

I tried to replicate the display of the videos based on the images.  Please also check the video and image display for glossary and DIS QC reports since the modified code is shared with those document types.

Here's what I'm seeing on DEV (updated 8/2 after additional testing):

• Summaries display videos and images as expected with one exception:

  • Videos and images that are in approved deletion markup are still displaying on the bold/underline QC report. I don't think they should appear since approved deletions are typically not shown on that report.

• DIS display videos but do not display images. (Do we have DIS with images and/or videos?) I see "Image:" in the QC report in the place of the media link.

• Glossary displays videos and images as expected.

I tried to replicate the display of the videos based on the images. 

The images were never properly marked up on the QC reports.  I have modified the filter to properly display images and videos for RS and B/U reports that may be in approved markup.  However, I did not make changes to include proper markup for proposed markup.  If we want that I'd suggest submitting a new ticket for a later release.

For the requested changes to the image display for DIS documents I'd also suggest a new ticket since that's a new feature as well.

The display of images and videos is still a bit inconsistent in the QC reports, but I think most of it can probably be attributed to where the caption is stored (in the media doc vs in the summary). I've attached a document with the findings for us to take a look at together.

The original goal of this ticket (displaying videos on QC reports) has been addressed. I think we need to move this up the tiers.

I've created OCECDR-4674 to address the inconsistencies mentioned above.

The filter changes have been copied to QA and STAGE.

Please verify before we're pushing the changes to PROD.

Unfortunately, I'm seeing the black x for videos on QA when I'm testing this now.

It appears the filter changes had been overwritten by various other releases.  I've restored the modified filter on DEV.  Give me a little more time to double-check that everything is working again.  The videos are displaying again on DEV at this point.

Give me a little more time to double-check that everything is working again.  The videos are displaying again on DEV at this point.

I completed my checking on DEV.  It's all yours, ~juther.

I've been trying to work on the linked issue but realizing that this issue isn't yet on PROD.

~juther, I've restored the filter on DEV as we discussed.

The original problem reported in this ticket has been fixed and videos are displaying on the QC reports on DEV. I confirmed this in both the patient B/U and RLSO QC reports. So we can move this up the tiers. Thanks Volker!

I ran a diff report for all available QC reports on QA and found no significant differences (except for a timestamp for the DrugInfoSummaries).  The updated filter has now been copied to STAGE and PROD:

• CDR339576: Module: InLine Markup Formatter
  https://github.com/NCIOCPL/cdr-server/commit/3092b26b
  https://github.com/NCIOCPL/cdr-server/commit/3f2f5733

Please verify on PROD and close this ticket.

Verified on PROD. Thanks!