CDR Tickets

Issue Number 4142
Summary Improve Error Message on Publishing Job Failure
Created 2016-08-08 17:16:50
Issue Type Improvement
Submitted By Englisch, Volker (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2017-03-31 15:57:07
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.191921
Description

If a weekend publishing job failed due to summary document failures the publishing job reports a failure as

  *** Error - Publication job failed

This error message is coming from the program SubmitPubJob.py.

It would make sense to elaborate on the error message a little and specify the reason for the failure like:

   *** Error - Publication job failed due to too many summary document failures
Comment entered 2017-03-29 15:55:37 by Englisch, Volker (NIH/NCI) [C]

I've modified SubmitPubJob.py to include a little more information if a publishing job fails or fails to start and this information is submitted via email also rather than just logging the information in a log file.

Currently testing and trying to make a publishing job fail in order to trigger the improved error messages.

Comment entered 2017-03-31 15:56:44 by Englisch, Volker (NIH/NCI) [C]

I have updated the following program

  • SubmitPubJob.py

If the publishing job fails I am now including the tail of the messages column and include this in the email message which includes the information of a failed publishing job due to too many document failures.
This has been successfully tested on DEV.

Comment entered 2017-08-08 18:16:13 by Kline, Bob (NIH/NCI) [C]

I'm moving this to the Feynman sprint, since the commit tied to this issue was made in the ocecdr-4268 branch.

Comment entered 2017-08-21 19:49:28 by Englisch, Volker (NIH/NCI) [C]

I'm not sure how this change ended up in the Feynman branch. I must have forgotten to update the comment because I already versioned the change in SVN:

  • R14845: SubmitPubJob.py

Comment entered 2017-08-21 19:54:48 by Kline, Bob (NIH/NCI) [C]

Not sure what you're saying here. Commit 14845 was made in the Feynman branch (that is, ocecdr-4268). Which comment were you saying needed to be updated?

Comment entered 2017-08-21 20:13:34 by Englisch, Volker (NIH/NCI) [C]

The comment in JIRA. I usually add the revision number somewhere in the comment after I versioned my changes. I didn't do that here.

Comment entered 2017-08-21 20:25:25 by Kline, Bob (NIH/NCI) [C]

Ah! Well, at least you put the JIRA ticket number in the svn comment, which is really the important piece, because not only does let you know where to go in JIRA if you're looking at the Subversion logs, but, JIRA is smart enough to parse your svn comment and add the link on the right side if the JIRA issue page to the commit. :-)

Comment entered 2017-09-12 15:01:33 by Englisch, Volker (NIH/NCI) [C]

I don't think it's a good idea to make the PROD publishing job fail in order to test the improved error messages. I'm afraid we will see those soon enough.
In the meantime I'm closing the ticket and reopening it if necessary.

Elapsed: 0:00:00.000718