Issue Number | 3149 |
---|---|
Summary | [HP Summary Section] Create new section at end of HP summaries |
Created | 2010-05-13 09:49:40 |
Issue Type | Improvement |
Submitted By | Beckwith, Margaret (NIH/NCI) [E] |
Assigned To | Englisch, Volker (NIH/NCI) [C] |
Status | Closed |
Resolved | 2010-08-30 11:21:16 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.107477 |
BZISSUE::4836
BZDATETIME::2010-05-13 09:49:40
BZCREATOR::Margaret Beckwith
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku
We will be adding a new section called About This PDQ Summary to the end of all HP summaries. It will be created using a series of Misc. Docs, placeholders, and by pulling info from the Board Org. records and the PDQ Board Member Info records. I am attaching the document with descriptions of how each section will be generated.
Attachment About This PDQ Summary_ lg edits_ImplemComments.doc has been added with description: Instructions for About This PDQ Summary section.
BZDATETIME::2010-05-26 13:25:21
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::1
I created a test misc. doc. on Mahler called About This PDQ Summary, with a Misc. Doc type of For more information--Health Professional Summary (671884). I still have questions about several placeholders and the Disclaimer section.
BZDATETIME::2010-06-02 18:43:16
BZCOMMENTOR::Volker Englisch
BZCOMMENT::2
I started working on this issue and I added the 'About This PDQ
Summary' information to the existing summaries.
For creating the first paragraph the instructions specify to fill in the
main topic term link.
Questions:
a) What do we do if there exist multiple main topic elements? Do we use
the
first one?
b) I am working with the Oral Cancer Screening summary and the main
topic is
'lip and oral cavity cancer'. Is this what we want for the replacement
text?
BZDATETIME::2010-06-03 08:54:54
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::3
I think in the end we decided that we would just make that text part of the summary placeholder text so you don't need to do anything with the main topic. Sorry about that--I missed that when I updated the document.
BZDATETIME::2010-06-07 15:31:46
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4
I have a question:
In the 'Permission to Use This Summary' section there is the text:
Date last modified <MM/DD/YYYY>. Available at:
www.cancer.gov/cancertopics.pdq/treatment/adultALL/healthprofessional/.
Accessed <MM/DD/YYYY>.
I'm guessing the dates (<MM/DD/YYYY>) should be printed
literally and not replaced with actual dates, right?
For the URL to the summary on Cancer.gov do we actually display the URL
or display the text of the SummaryURL field with the link used from the
SummaryURL attribute?
BZDATETIME::2010-06-07 17:21:49
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5
You're now able to use publish preview to view the new 'About This
PDQ Summary' section.
Please note that I still will need to finalize the Reviewers section
once we have the new/modified PlaceHolder element defined.
BZDATETIME::2010-06-14 14:17:51
BZCOMMENTOR::Volker Englisch
BZCOMMENT::6
The reviewer section has been implemented.
I hope I didn't forget anything.
This is ready for review on MAHLER.
BZDATETIME::2010-06-21 15:45:56
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::7
This is looking really great! The reviewer info looks just right.
I did notice that the link to the Levels of Evidence summary (using the LOESummary link from the Board Org record) isn't showing up:
Some of the reference citations in this summary are accompanied by a level-of-evidence designation. These designations are intended to help readers assess the strength of the evidence supporting the use of specific interventions or approaches. The PDQ Adult Treatment Editorial Board uses a formal evidence ranking system in developing its level-of-evidence designations.
The link should be from the words "formal evidence ranking system".
BZDATETIME::2010-06-22 18:59:24
BZCOMMENTOR::Volker Englisch
BZCOMMENT::8
I think I've finished the English version for this issue.
The LOE links are now being displayed based on the entry listed in
the board organization record. I have also created the BoardNameLink
placeholder which displays the board name and links (hard-coded) to the
Board Member page with the links used from this page:
http://www.cancer.gov/cancertopics/pdq/about-editorial-boards
I've also implemented the condition to only display the board reviewers if the ShowReviewerInfo in the board org record is set to 'Yes'.
I will start to implement the Spanish version now.
BZDATETIME::2010-07-21 15:51:01
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::9
I am raising the priority on this because I would really like to have this done before Volker and I are both gone the first week in August.
BZDATETIME::2010-07-23 13:23:32
BZCOMMENTOR::Volker Englisch
BZCOMMENT::10
I have modified the filters to a point where we can now run a PublishPreview for a Spanish summary on MAHLER. I'm currently working with CDR256715 - Cancer de la piel.
I have not yet addressed the PlaceHolder elements, so please ignore
these for now but I need a few text snippets to be translated:
a) The citation section needs to be translated
b) The text for the Lead Reviewers will need to be translated
i) The lead reviewer for <summary name> is
ii) The lead reviewers for <summary name> are
BZDATETIME::2010-07-23 18:46:24
BZCOMMENTOR::Volker Englisch
BZCOMMENT::11
We're getting closer with the Spanish version.
The PurposeText is being populated (if available in the summary itself)
The board names are being populated albeit in English
Margaret will add a task to add a BoardNameTranslation element to
the
board document
The LOE link has been set up
(when testing this in the PP report you'll have to replace the
substring
mahler.nci.nih.gov in the URL with cancer.gov to go to the proper
page)
A few English strings that are used in the filters still need to be translated and the display of the LeadReviewers has to be implemented for the Spanish summaries. I should be able to finish these remaining items early next week.
BZDATETIME::2010-07-30 17:45:26
BZCOMMENTOR::Volker Englisch
BZCOMMENT::12
I think I have everything ready now for user testing.
I had to create a new filter named:
Denormalization Filter: Summary Add Board Member - Spanish
which adds the board members of the related English summary to the
filtered output of the Spanish summary.
This filter is now member of the 'Summary Denormalization Set'
Because I am out all next week I have tried to get this ready for
review but I haven't had time to test the filter changes very
much.
When testing please make sure to test at least one summary for each of
these:
English/Spanish summaries
Summaries with a single board member/multiple board members
(note the different wording when listing the board members in
EN/ES)
Summaries for boards that do/do not want their information displayed
BZDATETIME::2010-08-05 12:56:15
BZCOMMENTOR::Bob Kline
BZCOMMENT::13
When the users tried testing they got errors from the publish preview interface complaining about an invalid 'Err' element; for example, testing with CDR552637. Tried to add Robin as a CC on this issue, but she wasn't in the picklist. Any idea what's going on there? I'm pretty certain she's been added as a CC on other issues (and in fact she's created some herself), so she seems to be in the system.
BZDATETIME::2010-08-05 22:58:40
BZCOMMENTOR::Volker Englisch
BZCOMMENT::14
(In reply to comment #13)
> When the users tried testing they got errors from the publish
preview
> interface complaining about an invalid 'Err' element;
This is an indication that the document couldn't be validated.
I would guess that some information is missing. That could be the
PurposeText or more likely the Misc. Doc. for which a version has to
exist or the board member information.
> Tried to add Robin as a CC on this issue, but she wasn't in
the
> picklist.
She's on my picklist. Not sure why she wouldn't be on yours.
I've added her now.
BZDATETIME::2010-08-10 16:29:26
BZCOMMENTOR::Volker Englisch
BZCOMMENT::15
(In reply to comment #13)
> Tried to add Robin as a CC on this issue, but she wasn't in
the
> picklist.
This has been fixed. She was a member of the "OCCM Content Group" but not the CDR Group. I saw Robin because I'm a member of both groups.
Are there still problems with the PublishPreview?
BZDATETIME::2010-08-11 16:53:24
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::16
Linda and I looked at pub preview for the Spanish summaries before she left for vacation. Here are her observations: (identified by the headings/sections):
1. Under "Propósito de este sumario", there is an extra period after 'tratamiento'. Please remove one.
2. Under "Revisores y actualizaciones", the "PDQ Supportive and Palliative Care Editorial Board" should be translated into Spanish. (will attach translation to issue).
3. Under "Grados de comprobación científica",
(a) "PDQ Supportive and Palliative Care Editorial Board" should be translated. (Will attach translation to issue).
(b) "un sistema formal de jerarquización de la medicina factual para" should be a link to the Levels of Evidence Summary. This link currently only shows up in the Misc. doc in the Adult Treatment summaries.
4. Under "Permisos para el uso de este sumario" Date last modified", "Available at" and "Accessed" should be all be translated. (Will attach translation to issue).
5. Under "Cláusula sobre el descargo de responsabilidad", the two
paragraphs are two different disclaimers but both are showing up Adult
and Pediatric and Supportive Care summaries.
According to Margaret:
The first disclaimer only applies to treatment summaries (Adults and
Peds) and the second one in other summaries (Supportive Care,
CAM).
If this is confusing, I have a print out of one publish
preview that is marked up to make it easier to identify the various
sections
Attachment QA Spanish Summaries.docx has been added with description: Spanish Summaries doc
BZDATETIME::2010-08-12 10:22:35
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::17
I just verified the new BoardNameTranslation ekement. Once that is promoted to Bach, then CIAT can put the translated name into each of the Board Org records. That should take care of the questions about translated names below. Also, just want to note that the new Editorial Board pages listing the Board members are now live on Cancer.gov (for Adult, Peds, and Supportive Care) so we can provide the link from the Board Name to those pages in Spanish now.
BZDATETIME::2010-08-12 19:41:02
BZCOMMENTOR::Volker Englisch
BZCOMMENT::18
Since there is no separate task for it I'm just adding the note here that I'm updated the CSS to include the BoardNameTranslation element.
This has been copied to FRANCK and BACH.
BZDATETIME::2010-08-13 11:59:16
BZCOMMENTOR::Volker Englisch
BZCOMMENT::19
(In reply to comment #16)
> 1. Under "Propósito de este sumario", there is an extra period
after
> 'tratamiento'. Please remove one.
This was part of the global to add the PurposeText. The final version
of the global will not include the period.
We should double-check our publishing test on FRANCK to ensure the
display of the period is OK.
> 2. Under "Revisores y actualizaciones", the "PDQ Supportive and
Palliative
> Care Editorial Board" should be translated into Spanish. (will
attach
> translation to issue).
This is now handled using the element BoardNameTranslation and the link for the Spanish documents points to the proper Spanish page.
> 3. Under "Grados de comprobación científica",
> (a) "PDQ Supportive and Palliative Care Editorial Board" should be
translated.
> (Will attach translation to issue).
This is now handled with the BoardNameTranslation element.
> (b) "un sistema formal de jerarquización de la medicina factual
para" should
> be a link to the Levels of Evidence Summary. This link currently
only
> shows up in the Misc. doc in the Adult Treatment summaries.
The LOESummary element has to be populated in the Board document for this link to appear.
> 4. Under "Permisos para el uso de este sumario" Date last
modified",
> "Available at" and "Accessed" should be all be translated. (Will
attach
> translation to issue).
If the translation for this part has already been provided I've
missed it.
Where can I find it?
> 5. Under "Cláusula sobre el descargo de responsabilidad", the
two paragraphs
> are two different disclaimers but both are showing up Adult and
Pediatric and
> Supportive Care summaries.
This has been fixed. The cdr:id in the Misc. document was missing the prefix '_treat' and '_other' for the different sections.
BZDATETIME::2010-08-13 12:47:42
BZCOMMENTOR::Volker Englisch
BZCOMMENT::20
We said at the meeting that the list of the reviewers should be in
alphabetic order.
I am guessing that the order should be by last name despite the fact
that the names are listed as 'FirstName LastName'. Is that correct?
BZDATETIME::2010-08-13 12:52:10
BZCOMMENTOR::Volker Englisch
BZCOMMENT::21
I have modified the citation section but have not followed exactly what we had discussed. It is now
National Cancer Institute: PDQ® Aspectos relacionados con la sexualidad y la reproducción . Bethesda, MD: National Cancer Institute. Date last modified <MM/DD/YYYY>. Available at: Aspectos relacionados con la sexualidad y la reproducción (PDQ®) (with a link to http://cancer.gov/espanol/pdq/cuidados-medicos-apoyo/sexualidad/HealthProfessional). Accessed <MM/DD/YYYY>.
I've added the URL as text after the link as an option to look
at.
If you'd prefer a different format I'll change it.
Please note that the "(with a link to ...)" is displayed in italics.
If we'd like to keep this version I would need the translated text to add this in Spanish as well.
BZDATETIME::2010-08-13 13:07:46
BZCOMMENTOR::Volker Englisch
BZCOMMENT::22
I believe I have completed most of the items discussed at our meeting
yesterday.
These are the issues that are left to do as far as I now:
Volker:
-------
[ ] Sort the display for multiple reviewers
[ ] Adjust the display of the citation section (translate to
Spanish,
display of URL)
CIAT:
-----
[ ] Add/update new elements BoardNameTranslation, ShowReviewerInfo,
LOESummary
to board documents
[ ] Adjust the cdr:id in the Misc. document for the disclaimer
sections
(prefeix '_treat'/'_other'
Alan:
-----
[ ] Run global to add PurposeText
[ ] Remove About PDQ section
Alan/CIAT:
----------
[ ] Fix linking problem to the old 'About PDQ' section.
BZDATETIME::2010-08-13 13:11:05
BZCOMMENTOR::Volker Englisch
BZCOMMENT::23
It might be a good idea to add Alan as a CC to this task so he knows when we talk about him.
BZDATETIME::2010-08-17 15:58:37
BZCOMMENTOR::Volker Englisch
BZCOMMENT::24
(In reply to comment #22)
> [X] Sort the display for multiple reviewers
The filters have been updated to sort the list of board members alphabetically by last name.
BZDATETIME::2010-08-17 17:27:33
BZCOMMENTOR::Robin Juthe
BZCOMMENT::25
(In reply to comment #15)
> Are there still problems with the PublishPreview?
I am still having problems with PublishPreview on Mahler for some summaries - particularly screening summaries, prevention summaries, CAM summaries, and genetics summaries. I'm receiving the 'Err' message mentioned above, despite the document validating properly. I'm not sure if this is related to the linking problem Alan mentioned in issue 4838.
Some examples include: CDR62863, CDR62753, CDR62758, CDR347008
BZDATETIME::2010-08-17 17:28:10
BZCOMMENTOR::Robin Juthe
BZCOMMENT::26
I have reviewed several adult treatment, pediatric treatment, and supportive care summaries in English. In general, things look great! I have a few specific comments (some of which will address other questions posted):
1. I noticed some double-periods after the PurposeText placeholder. Examples: CDR62792, CDR62951. I expect that these will disappear when we run it on Bach since the spreadsheet was modified, but I thought I would mention it since I think we were expecting extra periods in Spanish, but not in English?
2. The LOE summary that is being linked to from English summaries is in Spanish. I checked the org records and they appear to be linked to the English LOE summary. Examples: CDR 276584, CDR62792
3. I don't think it's necessary to have the hyperlinked text in the
citation. I would prefer the citation format to be:
National Cancer Institute: PDQ® Aspectos relacionados con la sexualidad
y la
reproducción. Bethesda, MD: National Cancer Institute. Date last
modified
<MM/DD/YYYY>. Available at: http://cancer.gov/espanol/pdq/cuidados-medicos-apoyo/sexualidad/HealthProfessional.
Accessed <MM/DD/YYYY>.
I think we still need "Available at", Accessed", and "Date Last Modified" to be translated into Spanish.
4. The alphabetical by Last Name sequence looks great. I tested this in several summaries.
Thanks!
BZDATETIME::2010-08-17 18:50:40
BZCOMMENTOR::Volker Englisch
BZCOMMENT::27
(In reply to comment #25)
> I am still having problems with PublishPreview on Mahler for some
summaries -
> particularly screening summaries, prevention summaries, CAM
summaries, and
> genetics summaries.
I think I found the problem. The filter - in order to collect all information it needs at the end when assembling the new section - retrieves the information from all linked documents. Part of this "hording" of the filter includes to retrieve the summary that is the English translation of the LOE document. The filter fails for those English summary types for which no Spanish translation exists.
I will fix that tomorrow.
> I'm receiving the 'Err' message mentioned above, despite
> the document validating properly.
The validation in XMetaL determines that the document is valid
according to our CDR schema and you're allowed to save a valid and/or
publishable version of the document.
The 'Err' message is a message coming from Cancer.gov meaning that the
document that we have submitted (to create the publish preview output)
is not valid according to our publishing DTD. In other words, our
publishing filters didn't create valid output.
> I'm not sure if this is related to the linking problem Alan
mentioned in
> issue 4838.
It's not. It is related to the missing Spanish LOE documents.
Thank you for providing the document IDs that failed! That makes hunting down the problems easier.
BZDATETIME::2010-08-17 21:14:07
BZCOMMENTOR::Alan Meyer
BZCOMMENT::28
(In reply to comment #26)
...
> 1. I noticed some double-periods after the PurposeText placeholder.
Examples:
> CDR62792, CDR62951. I expect that these will disappear when we run
it on Bach
> since the spreadsheet was modified, but I thought I would mention
it since I
> think we were expecting extra periods in Spanish, but not in
English?
Vice-versa. It was the English that had the periods in the spreadsheet.
You're right that this problem should go away when we run again.
The
latest version of the global change eliminates final periods from
any
PurposeText. Volker's publishing filter should then put it back on.
BZDATETIME::2010-08-18 16:16:46
BZCOMMENTOR::Volker Englisch
BZCOMMENT::29
(In reply to comment #25)
> I am still having problems with PublishPreview on Mahler for some
summaries -
> ...
> Some examples include: CDR62863, CDR62753, CDR62758, CDR347008
I have fixed the filters and I'm now able to run the PP for these
summaries.
Thinking about this I will also need to look into the situation when a
new treatment and supportive care summaries has been created but a
Spanish translation isn't available yet.
BZDATETIME::2010-08-18 17:34:01
BZCOMMENTOR::Volker Englisch
BZCOMMENT::30
(In reply to comment #26)
> 1. I noticed some double-periods
Only a problem on MAHLER.
> 2. The LOE summary that is being linked to from English
summaries is in
> Spanish.
That was a bug in the filter. Fixed now.
> 3. I don't think it's necessary to have the hyperlinked text in the citation.
I have updated the citation section and included the Spanish translation.
BZDATETIME::2010-08-19 18:15:23
BZCOMMENTOR::Volker Englisch
BZCOMMENT::31
I'm starting to prepare publishing on FRANCK with the new filters and
I'm noticing that the two new misc. documents don't exist yet.
I can create these documents myself by copying the version from MAHLER
but considering that these documents are essential to the publishing
process I would feel much better if I knew that the "About This PDQ
Summary" documents already existed and were correctly formatted.
Also, since I am referring to these documents via their CDR-ID, the ID
would have to be changed twice in the filter, once for testing on FRANCK
and once for running the job on BACH.
Would you want me to create the documents on BACH, Margaret, or should we have CIAT create them?
BZDATETIME::2010-08-20 09:34:26
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::32
Oh darn! How did I miss this? I guess we should have CIAT do it. I will ask them to create them on Franck and on Bach.
BZDATETIME::2010-08-20 09:50:29
BZCOMMENTOR::Volker Englisch
BZCOMMENT::33
Would you rather have me to create them on FRANCK? That way I could at least run a publishing job today and make sure everything is working right.
BZDATETIME::2010-08-20 12:30:38
BZCOMMENTOR::Volker Englisch
BZCOMMENT::34
I finished moving all changes to FRANCK and this is the list of things that need to happen in order for publishing the new summary section to succeed:
[ ] Running the "Add Purpose Text element" global (Alan)
[ ] Running the "Remove Purpose Section" global (Alan)
[ ] Fix links to removed purpose section (Alan)
[ ] Create and version❗ Misc. Documents (CIAT/Volker)
About This Summary
Información sobre este sumario del PDQ
with all of the proper PlaceHolder elements
PurposeOfSummary
BoardNameLink
BoardName
LOELink
LeadReviewers
PdqCitation
and ensure the cdr:ids for the disclaimer are prefixed with the
_treat or _other
string.
[ ] Update the Schema and XMetaL DTD (Bob)
[ ] Update the vendor filter (CDR157) to list the CDR-ID of the misc.
docs
used for the denormalization. (Volker)
[ ] Update the filters (Volker)
CDR000157 - Vendor Filter: Summary
CDR335424 - Denormalization Filter: Summary
CDR682668 - Denormalization Filter: Summary Add Board Member -
Spanish
[X] Adjust the Summary filter sets (Volker)
add CDR682668 to "Summary Denormalization Set"
[X] Add new query terms to query term table and re-index
(Volker)
/PDQBoardMemberInfo/Affiliations/Affiliation/@Usage
/PDQBoardMemberInfo/Affiliations/Affiliation/AffiliationName
/PDQBoardMemberInfo/Affiliations/Affiliation/AffiliationPlace
BZDATETIME::2010-08-20 13:03:46
BZCOMMENTOR::Volker Englisch
BZCOMMENT::35
The publishing job ran successfully on FRANCK.
I had a quick look at the diff report and did not see any differences
except for the new 'About This' section.
One summary failed because the English version of the summary (Small
Intestine Cancer Treatment - CDR350260) is listing two entries for the
Editorial Board.
This should get fixed.
I will now run another publishing job and load the output to GatekeeperGK for preview.
BZDATETIME::2010-08-20 14:50:12
BZCOMMENTOR::Volker Englisch
BZCOMMENT::36
The summaries have been updated to GatekeeperGK and can be previewed
at
http://wwwgk.cancer.gov/cancertopics
Please note:
There were 8 summaries that failed loading on Gatekeeper. I'll
investigate these and report back.
BZDATETIME::2010-08-20 17:30:35
BZCOMMENTOR::Robin Juthe
BZCOMMENT::37
Margaret and I just looked at a few of the non-treatment summaries in PP on Mahler and came across a few issues:
1. Overview summaries (Cancer Genetics Overview, Cancer Screening Overview, and Cancer Prevention Overview). We do not want to show the list of reviewers for these summaries, since it is really just a list of the entire Board (not exactly "lead" reviewers).
2. Level of evidence summaries. We do not want these summaries to have the new "About this PDQ Summary" section.
3. In the non-treatment summaries, the disclaimer text should have a link to the "Coping with Cancer" page (as is in the treatment disclaimer paragraph). I think this external ref just needs to be added to the misc. document.
4. One of the Genetics Board members, Danielle Kim Turgeon, is showing up twice and with 2 affiliations in the list of reviewers for the Cancer Genetics Overview summary (CDR 517309). This issue may become moot when we figure out a way to not display the list of reviewers in overview summaries (her affiliation looks fine in CDR 62863), but I thought I would mention it just in case. She only has one Board member document with one affiliation.
5. One of the Screening and Prevention Board members, Jean Fourcroy, does not have an affiliation, so her name is followed by empty parentheses. She's retired; it may be best to show no parentheses at all in this case?
We will look at some more summaries on Monday, but I wanted to post those few things we saw thus far.
BZDATETIME::2010-08-20 17:53:13
BZCOMMENTOR::Volker Englisch
BZCOMMENT::38
Linda checked out the Spanish summaries and found a few things I'd like to list here to make sure they don't fall on the floor:
the "n" is missing from Última actualización
a colon needs to be added after Última actualización and Fecha de acceso
a colon and the word Tratamiento are showing in the
LeadReviewers
sentence as in the Cáncer del seno summary
the BOARDNAMELink under the Reviewers and Updates and the
BOARDNAME link
under the Levels of Evidence sections are missing (Childhood Liver
Cancer/
Cáncer del hígado infantil)
BZDATETIME::2010-08-20 18:12:23
BZCOMMENTOR::Volker Englisch
BZCOMMENT::39
(In reply to comment #38)
> - the "n" is missing from Última actualización
Fixed on MAHLER.
> - a colon needs to be added after Última actualización and Fecha de acceso
Fixed on MAHLER.
> - a colon and the word Tratamiento are showing in the LeadReviewers
Fixed on MAHLER.
> sentence as in the Cáncer del seno summary
> - the BOARDNAMELink under the Reviewers and Updates and the
BOARDNAME link
> under the Levels of Evidence sections are missing (Childhood Liver
Cancer/
> Cáncer del hígado infantil)
This is a data issue. The BoardNameTranslation for the PEDs board has not been entered yet.
BZDATETIME::2010-08-23 11:15:33
BZCOMMENTOR::Volker Englisch
BZCOMMENT::40
(In reply to comment #37)
> 1. Overview summaries (Cancer Genetics Overview, Cancer Screening
Overview,
> and Cancer Prevention Overview). We do not want to show the list
of
> reviewers for these summaries
Is there a better way to uniquely identify "Overview" summaries other
than specifying the CDR-IDs?
Looking at the SummaryTitle using the rule "Title ends in Overview"
isn't sufficient due to the "Childhood Brain and Spinal Cord Tumors
Treatment Overview" summary.
> 2. Level of evidence summaries. We do not want these summaries
to have the new
> "About this PDQ Summary" section.
Done on MAHLER.
> 3. In the non-treatment summaries, the disclaimer text should
have a link to
> the "Coping with Cancer" page (as is in the treatment disclaimer
paragraph). I
> think this external ref just needs to be added to the misc.
document.
Correct.
> 4. One of the Genetics Board members, Danielle Kim Turgeon, is
showing
> up twice and with 2 affiliations in the list of reviewers for the
Cancer
> Genetics Overview summary (CDR 517309).
This appears to be a data issue since the person has been entered twice in the list of reviewers for this summary.
> 5. One of the Screening and Prevention Board members, Jean
Fourcroy, does not
> have an affiliation, so her name is followed by empty parentheses.
She's
> retired; it may be best to show no parentheses at all in this
case?
Done on MAHLER.
BZDATETIME::2010-08-23 17:35:25
BZCOMMENTOR::Volker Englisch
BZCOMMENT::41
(In reply to comment #40)
> Looking at the SummaryTitle using the rule "Title ends in Overview"
isn't
> sufficient due to the "Childhood Brain and Spinal Cord Tumors
Treatment
> Overview" summary.
I've modified the filter to suppress the display of the board members for the overview summaries by specifying (a.k.a hard coding) the summary titles specifically.
BZDATETIME::2010-08-24 10:47:38
BZCOMMENTOR::Robin Juthe
BZCOMMENT::42
(In reply to comment #35)
> One summary failed because the English version of the summary
(Small Intestine
> Cancer Treatment - CDR350260) is listing two entries for the
Editorial Board.
> This should get fixed.
This summary has been fixed. The problem was in the patient version, not the HP.
BZDATETIME::2010-08-24 11:00:39
BZCOMMENTOR::Volker Englisch
BZCOMMENT::43
FYI:
The CDR database on FRANCK has been refreshed.
Alan is in the process of running his global updates right now.
BZDATETIME::2010-08-24 15:31:33
BZCOMMENTOR::Volker Englisch
BZCOMMENT::44
(In reply to comment #42)
> This summary has been fixed. The problem was in the patient
version, not the
> HP.
Did this get fixed after 10pm yesterday?
I ran the publishing job on FRANCK and see the same error which may be
OK if the document got fixed today instead of yesterday.
BZDATETIME::2010-08-24 16:05:27
BZCOMMENTOR::Robin Juthe
BZCOMMENT::45
Yes, it was corrected this morning.
BZDATETIME::2010-08-24 17:42:39
BZCOMMENTOR::Volker Englisch
BZCOMMENT::46
A few things that I noticed on FRANCK while looking at the publishing output which need to get fixed before we're running the final publishing on BACH:
The Spanish misc. doc will need to be versioned
The Title element in the misc. doc for English is not wrapped
with the
Strong element. I don't think this matters for the output on
Cancer.gov
but for consistency sake we should have the EN and ES version the
same.
There is an empty Para element in the EN misc. doc
The PlaceHolder for LeadReviewers is missing in the EN misc. doc
The PlaceHolder for LeadReviewers in the ES misc. doc shouldn't be in a Para
There is a link missing in the _other Disclaimer Para in the EN misc doc
The BoardNameTranslation will need to be added for each
board
(I believe that's already done but had not been last night.)
BZDATETIME::2010-08-24 18:05:49
BZCOMMENTOR::Volker Englisch
BZCOMMENT::47
The data from FRANCK has been loaded to
http://wwwgk.cancer.gov/cancertopics
but it appears that the LeadReviewers are not displayed in the Spanish
version. This is due to the fact that the PlaceHolder was listed within
a Para element.
I'll check this out tomorrow.
BZDATETIME::2010-08-25 14:12:49
BZCOMMENTOR::Volker Englisch
BZCOMMENT::48
My last comment was incorrect. The reason why the Spanish LeadReviewers did not show up was a missing filter in the filter set on FRANCK.
I reran the publishing job and loaded all summaries to the test
site:
http://wwwGK.cancer.gov/
Except for the 8 documents that failed loading yesterday everything should be OK now.
BZDATETIME::2010-08-25 17:34:42
BZCOMMENTOR::Volker Englisch
BZCOMMENT::49
(In reply to comment #48)
> Except for the 8 documents that failed loading yesterday everything
should be
> OK now.
These 8 summaries have been resolved as well.
The 7 genetics summaries failed because the url attribute of the
SummaryRef element to the LOE document was empty. The reason for this is
that I have to use the part after the host name (i.e. http://www.cancer.gov) to populate the
url.
It appears that all summaries are listing the SummaryURL attribute
as
http://www.cancer.gov/...
while the genetics summaries are listing
http://cancer.gov/...
Since I was looking for the string that starts with http://www.cancer.gov the genetics
summaries were left empty handed.
This has now been fixed and either notation can be used.
For the last summary that failed loading on GatekeeperGP Min has confirmed that this error is due to the old data on the GK server and the problem causing this summary to fail is already corrected on the live server.
It looks like everything is working at this point and all we need is the green light to move everything to BACH.
BZDATETIME::2010-08-26 08:59:46
BZCOMMENTOR::Volker Englisch
BZCOMMENT::50
In anticipation of finishing up this task very soon I've versioned
the modified filters:
CDR682668 - Denormalization Filter: Summary Add Board Member - Spanish
(R9853)
CDR335424 - Denormalization Filter: Summary (R9853)
CDR000157 - Vendor Filter: Summary (R9853)
BZDATETIME::2010-08-26 09:13:07
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::51
I think we're good to go on Bach!
BZDATETIME::2010-08-26 10:20:06
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::52
(In reply to comment #50)
> In anticipation of finishing up this task very soon I've versioned
the modified
> filters:
> CDR682668 - Denormalization Filter: Summary Add Board Member -
Spanish
> (R9853)
> CDR335424 - Denormalization Filter: Summary
> (R9853)
> CDR000157 - Vendor Filter: Summary
> (R9853)
Should we expect that the Spanish summaries should be OK on the test site now? Linda checked and it does not appear to be the case.
BZDATETIME::2010-08-26 10:25:39
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::53
What test site is she looking at? I looked at several Spanish summaries on GKcancer.gov and they looked fine except for the BoardNameTranslation which hadn't been entered on Franck.
BZDATETIME::2010-08-26 10:35:42
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::54
(In reply to comment #53)
> What test site is she looking at? I looked at several Spanish
summaries on
> GKcancer.gov and they looked fine except for the
BoardNameTranslation which
> hadn't been entered on Franck.
Right, her findings had to do with the BoardNameTranslation so it looks like we are good.
BZDATETIME::2010-08-27 09:08:52
BZCOMMENTOR::Volker Englisch
BZCOMMENT::55
We ran the publishing job for summaries yesterday and loaded all of
the documents to the Cancer.gov preview site:
http://preview.cancer.gov/
Unfortunately, Alan's and my paths crossed and his global to update
the Spanish PurposeText element hadn't finished by the time publishing
ran and therefore all of the Spanish documents now say "*** UNSPECIFIED
PURPOSE TEXT ***".
Everything else looks good as far as I can tell.
Since Alan identified a few documents that had errors and warnings in
addition to the few documents that were checked out during the global
run we should probably wait and give everyone the opportunity to fix the
existing problems before I rerun the summary publishing job.
Another option would be to run the publishing now to fix the Spanish
documents and update the summaries with problems as hot-fixes.
I guess this is a question for Margaret and Robin:
Which option would you prefer?
BZDATETIME::2010-08-27 09:59:15
BZCOMMENTOR::Volker Englisch
BZCOMMENT::56
I found a bug in the filters:
It appears that the filter is not identifying correctly the number of
AffiliationNames to be displayed.
See Non-small cell lung cancer treatment, Janet Dancey as an example. An
extra ampersand is displayed.
BZDATETIME::2010-08-27 11:31:11
BZCOMMENTOR::Volker Englisch
BZCOMMENT::57
The Spanish summary PurposeText has now been updated on the preview
site
http://preview.cancer.gov/
BZDATETIME::2010-08-27 15:45:09
BZCOMMENTOR::Volker Englisch
BZCOMMENT::58
Modified filter to properly display the Affiliation Names for Janet
Dancey:
CDR335424 - Denormalization Filter: Summary (R9855)
BZDATETIME::2010-08-27 22:09:56
BZCOMMENTOR::Volker Englisch
BZCOMMENT::59
All of the summaries are now on Cancer.gov.
Our Re-publish tool doesn't allow us to specify a target on
Cancer.gov and I thought the output goes directly to Live. However, it
was sitting on Preview and I had to manually copy the summaries to
Live.
This means that the summary publishing job just finished but the weekly
publishing job failed since the summary job was still processing.
I will start the weekly publishing job tomorrow morning.
Any remaining problems with the summaries can now be addressed with hot-fix updates where necessary.
BZDATETIME::2010-08-30 11:21:16
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::60
Everything live on Cancer.gov. Issue closed.
File Name | Posted | User |
---|---|---|
About This PDQ Summary_ lg edits_ImplemComments.doc | 2010-05-13 09:49:40 | |
QA Spanish Summaries.docx | 2010-08-11 16:53:24 | Osei-Poku, William (NIH/NCI) [C] |
Elapsed: 0:00:00.001814