CDR Tickets

Issue Number 3152
Summary Macro for selecting a value for LastReviewedStatus attribute
Created 2010-05-13 16:50:29
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2010-06-01 12:27:56
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107480
Description

BZISSUE::4839
BZDATETIME::2010-05-13 16:50:29
BZCREATOR::William Osei-Poku
BZASSIGNEE::Bob Kline
BZQACONTACT::William Osei-Poku

In the summary document type, we have added a LastReviewedStatus attribute to the ProtocolRef element. Please, create a macro for populating the values for the LastReviewedStatus attribute.

In the CDR status meeting today, we decided to go with the option of the user pointing the cursor at the ProtocolRef link and invoking the macro to populate the attribute.

Comment entered 2010-05-18 09:03:01 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-05-18 09:03:01
BZCOMMENTOR::Bob Kline
BZCOMMENT::1

The top priority end of my queue of tasks consists of a dozen P5 issues. Unless it makes no difference which I address first, it would be helpful to have the priorities reflect the order in which I should tackle the tasks.

Comment entered 2010-05-19 10:31:10 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-05-19 10:31:10
BZCOMMENTOR::Bob Kline
BZCOMMENT::2

Implemented on Mahler; ready for user review.

Comment entered 2010-05-19 11:30:55 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-05-19 11:30:55
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::3

(In reply to comment #2)
> Implemented on Mahler; ready for user review.

I am getting "Unable to find status for CDR [123456]" when the linked protocol is a CTGovProtocol document type.

Also, since we have a LastReviewedStatus attribute, I propose that we change the LastReviewed attribute to LastReviewedDate attribute. Can this change be done in this issue or you need me to create another issue or re-open the closed issue for when we created the LastReviewed attribute?

Comment entered 2010-05-19 12:04:37 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-05-19 12:04:37
BZCOMMENTOR::Bob Kline
BZCOMMENT::4

(In reply to comment #3)

> I am getting "Unable to find status for CDR [123456]" when the linked protocol
> is a CTGovProtocol document type.

I have expanded the macro to look for status in both types of protocol documents.

> Also, since we have a LastReviewedStatus attribute, I propose that we change
> the LastReviewed attribute to LastReviewedDate attribute. Can this change be
> done in this issue or you need me to create another issue or re-open the closed
> issue for when we created the LastReviewed attribute?

Have you run this by Lakshmi or Margaret? What do you propose to do with the documents which are already using this attribute under the old name (the schema change has been in production for several months)? Global change issue?

Comment entered 2010-05-19 13:12:47 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-05-19 13:12:47
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::5

(In reply to comment #4)
> (In reply to comment #3)
>
> > I am getting "Unable to find status for CDR [123456]" when the linked protocol
> > is a CTGovProtocol document type.
>
> I have expanded the macro to look for status in both types of protocol
> documents.
>

Verified. This can be promoted to Bach. Thanks!

> > Also, since we have a LastReviewedStatus attribute, I propose that we change
> > the LastReviewed attribute to LastReviewedDate attribute. Can this change be
> > done in this issue or you need me to create another issue or re-open the closed
> > issue for when we created the LastReviewed attribute?
>
> Have you run this by Lakshmi or Margaret?

I will bring this issue up at the meeting on Thursday.

>What do you propose to do with the
> documents which are already using this attribute under the old name (the schema
> change has been in production for several months)? Global change issue?

This attribute has not been used in many summaries. We can make changes manually to the few that have already used this attribute. (If we can get a list of all the ones that currently have this attribute on Bach that will be helpful). In fact, this request falls into the same category as the StatusType attribute (currently on Bach) which we have now changed to LastReviewedStatus (on Mahler). There will not be the need for a global because we have not used these attributes extensively.

Comment entered 2010-05-20 15:53:54 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-05-20 15:53:54
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::6

(In reply to comment #5)
>
> > > Also, since we have a LastReviewedStatus attribute, I propose that we change
> > > the LastReviewed attribute to LastReviewedDate attribute. Can this change be
> > > done in this issue or you need me to create another issue or re-open the closed
> > > issue for when we created the LastReviewed attribute?
> >
> > Have you run this by Lakshmi or Margaret?
>
> I will bring this issue up at the meeting on Thursday.

The above request is now being tracked under OCECDR-3162.

Per comment #5, the original issue in this bug can be promoted Bach

Comment entered 2010-05-21 13:09:17 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-05-21 13:09:17
BZCOMMENTOR::Bob Kline
BZCOMMENT::7

I'll promote this after business hours in order not to have the CDR server upgrade interrupt CIAT's work.

Comment entered 2010-05-26 10:52:36 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-05-26 10:52:36
BZCOMMENTOR::Bob Kline
BZCOMMENT::8

Promoted to Bach; please check carefully.

Comment entered 2010-06-01 12:27:56 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-06-01 12:27:56
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::9

(In reply to comment #8)
> Promoted to Bach; please check carefully.

Verified on Bach. Issue Closed. Thanks!

Elapsed: 0:00:00.000450