EBMS Tickets

Issue Number 751
Summary [Travel] Fix Bug in Hotel and Reimbursement Email Code
Created 2023-03-31 17:35:58
Issue Type Bug
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2023-04-06 13:41:43
Resolution Fixed
Path /home/bkline/backups/jira/oceebms/issue.342629
Description

Per OCEEBMS-749:

 

There's a bug in the code which is causing the messages to fail, but only on production. The page where I set the recipients is setting the value of the

 

email_travel.email.travel_manager

variable. But the reimbursement request for and the hotel request form are both looking for the

email_travel.email.manager

variable.

Comment entered 2023-04-06 13:41:43 by Kline, Bob (NIH/NCI) [C]

Fixed on DEV. I had installed a temporary patch which caused DEV to behave as if it were PROD, sending messages to the registered travel managers even from that lower tier, and that was tested successfully. We can't deploy it that way, though, so I have committed the fix without the temporary patch, which has been backed out on DEV.

https://github.com/NCIOCPL/ebms/commit/1f50b23

Comment entered 2023-06-01 14:15:19 by Shields, Victoria (NIH/NCI) [E]

The contractor is receiving reimbursement requests on PROD. They also received a hotel request from test board member. Verified on PROD.

Elapsed: 0:00:00.000635