EBMS Tickets

Issue Number 750
Summary [Packets] Board Member packets don't show related articles
Created 2023-03-29 19:57:20
Issue Type Improvement
Submitted By Shields, Victoria (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2023-04-07 09:53:15
Resolution Fixed
Path /home/bkline/backups/jira/oceebms/issue.342440
Description

In the Board members' packets, the related articles text does not show.

On DEV, in the Gastric (March 2023) packet, Ilson and Kelly are linked as related articles but this text is not displayed.

Comment entered 2023-03-29 20:36:59 by Kline, Bob (NIH/NCI) [C]

Which page, please? (e.g., board member or board manager? fyi? reviewed? awaiting review?)

Comment entered 2023-04-06 16:47:55 by Shields, Victoria (NIH/NCI) [E]

Board members' packets that are in their queues waiting to be reviewed.

Comment entered 2023-04-06 17:32:18 by Kline, Bob (NIH/NCI) [C]

I found the old code. One thing I noticed about it is that it showed the first author's surname at the front if any authors had a surname, and otherwise it displayed "[No authors listed]" even if there were one or more corporate authors for the article. Do you want the new site to continue that behavior?

Comment entered 2023-04-06 18:17:58 by Shields, Victoria (NIH/NCI) [E]

By "corporate" do you mean when the authors are a clinical trials group or something like that?

Comment entered 2023-04-06 20:19:34 by Kline, Bob (NIH/NCI) [C]

Something like that. There are about 26,000 such names, so perhaps hard to generalize. Here are some examples:

  • Royal Thai College of Obstetricians and Gynaecologists (RTCOG)/JHPIEGO Corporation Cervical Cancer Prevention Group

  • Methamphetamine Treatment Project Corporate Authors

  • ProAssurance Corporation

  • Breast Surgeons of Australia and New Zealand Incorporated (BreastSurgANZ)

  • Extracorporeal Life Support Organization Member Centers

  • Laboratory Corporation of America Variant Classification Group

  • Pediatric ECMO (PediECMO) subgroup of the Pediatric Acute Lung Injury and Sepsis Investigators (PALISI) Network and the Extracorporeal Life Support Organization (ELSO)

  • ELCAP Group

  • BGMT Study Group

  • CHEK2-Breast Cancer Consortium

  • Surgical Subcommitte of the European Osteosarcoma Intergroup

  • Austrian Berlin-Frankfurt-Münster Study Group

  • Southwest Oncology Group

  • AIDS Malignancy Consortium

Comment entered 2023-04-07 09:53:15 by Kline, Bob (NIH/NCI) [C]

Fixed on DEV. I see that we have used that logic for authors of related articles everywhere in the system, so changing that would be out of scope for this ticket (if it's worth doing at all).

https://github.com/NCIOCPL/ebms/commit/5eafbcf

Comment entered 2023-04-20 11:32:16 by Shields, Victoria (NIH/NCI) [E]

Verified on DEV.

Comment entered 2023-05-03 17:09:06 by Shields, Victoria (NIH/NCI) [E]

Verified on QA.

Comment entered 2023-05-16 18:55:55 by Shields, Victoria (NIH/NCI) [E]

This is difficult to test without seeing a real Board member's packet, but it works for the test accounts on PROD.

Elapsed: 0:00:00.000751