EBMS Tickets

Issue Number 748
Summary [Reviewed Packets] "New" designation not working correctly
Created 2023-03-13 10:56:42
Issue Type Bug
Submitted By Shields, Victoria (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2023-04-21 10:44:34
Resolution Fixed
Path /home/bkline/backups/jira/oceebms/issue.340750
Description

On the Board manager's Reviewed Packets page, the "new" designation is not disappearing when packets are opened.

Comment entered 2023-03-13 11:47:24 by Kline, Bob (NIH/NCI) [C]

Was this working correctly during testing?

Comment entered 2023-03-13 12:09:42 by Shields, Victoria (NIH/NCI) [E]

Yes, this worked during testing.

Comment entered 2023-03-13 12:44:07 by Kline, Bob (NIH/NCI) [C]

I'm seeing the correct behavior on https://ebms.rksystems.com (I can't log in as the board manager on the CBIIT-hosted servers.) Can you provide exact steps for reproducing the bug? (You remember that only the board manager for the review's board gets the "New" designation, right?)

Comment entered 2023-03-13 12:58:27 by Shields, Victoria (NIH/NCI) [E]

Would it be helpful if I set up a quick WebEx session so you can see my screen?

Comment entered 2023-03-13 13:05:44 by Kline, Bob (NIH/NCI) [C]

Yes, let's do that.

Comment entered 2023-03-13 15:10:21 by Kline, Bob (NIH/NCI) [C]

I was able to reproduce the behavior. I had conflated this ticket with OCEEBMS-747, for which I was not able to reproduce the failure to have the home page alert for the number of new reviews increase when a board member submitted a new review. As far as I can determine, the bug reported by this ticket has always been there, since the page was first implemented back in May. I examined every one of the six versions of the code for that page, and none of those versions included the code to update the last_seen field for the packet when it was viewed by the board manager. Fixed on https://ebms.rksystems.com and https://ebms-dev.nci.nih.gov.

Comment entered 2023-03-30 12:57:47 by Shields, Victoria (NIH/NCI) [E]

Verified on DEV.

Comment entered 2023-03-30 12:58:04 by Shields, Victoria (NIH/NCI) [E]

Verified on DEV.

Comment entered 2023-04-06 11:41:38 by Kline, Bob (NIH/NCI) [C]

https://github.com/NCIOCPL/ebms/commit/f4c4bb0

Comment entered 2023-04-21 10:28:18 by Juthe, Robin (NIH/NCI) [E]

This was inadvertently added to QA verified but hasn't been verified on that tier yet. I'm not able to move it back to the DONE column so adding a comment instead.

Comment entered 2023-05-03 17:42:49 by Shields, Victoria (NIH/NCI) [E]

Verified on QA.

Comment entered 2023-05-16 18:52:08 by Shields, Victoria (NIH/NCI) [E]

I haven't received any new reviews yet, but other Board managers have reported that the "new" designation appears when new article reviews are submitted and disappears when packets have been opened. Verified on PROD.

Elapsed: 0:00:00.000599