CDR Tickets

Issue Number 5316
Summary Modify Fetch English Summary For Translation tool to include Standard Wording elements
Created 2024-01-16 16:12:09
Issue Type Task
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Resolved
Resolved 2024-02-13 11:17:25
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.386681
Description

We excluded Standard Wording elements from the Fetch English Summary for Translation tool in Pauling OCECDR-5161.   However, we are now finding out that excluding the element is causing some text content that really needs to be translated. That is, we do not want to exclude all content. However, there is currently no way to identify the content that needs to be excluded and which content to include. So, we would like to reverse the changes. Would this require a release?

Comment entered 2024-01-18 08:45:24 by Kline, Bob (NIH/NCI) [C]

You didn't mention the other day when we were discussing the StandardWording element that it's an inline element, and that if we strip the tags they'll still be enclosed inside the block-level element in which they are contained, which would mean that the document would still be valid. Would you like the script to do that instead of strip the entire element? If yes, would you still want that to be optional?

Comment entered 2024-01-18 14:14:36 by Osei-Poku, William (NIH/NCI) [C]

Yes, please proceed to strip the tags but don't make it optional.

Comment entered 2024-01-18 15:52:42 by Kline, Bob (NIH/NCI) [C]

OK. I did the implementation for this on my DEV VM, so I wouldn't disrupt anyone trying to use the script on DEV, in case my experiment broke it. I used CDR62888 to test. The first screenshot shows the form with the new field. The second screenshot shows my first cut (with the stripping of the StandardWording elements made optional), just to show where the element is found in the document. The final screenshot shows the document with the tags stripped but the element content preserved.

https://nciws-d2019-v.nci.nih.gov/cgi-bin/cdr/get-english-summary.py


 

Please test. If this does what you want, I'll port it over to CDR DEV.

(As a side note, as part of the work on this enhancement I stumbled on and fixed a bug, which caused "pub" or "last" in the version field to fail.)

Comment entered 2024-01-19 11:32:40 by Osei-Poku, William (NIH/NCI) [C]

Thank you very much   This is very helpful. We will run a few tests and then begin using it. Appreciated much!

Comment entered 2024-02-01 11:24:52 by Osei-Poku, William (NIH/NCI) [C]

This looks good. Please proceed with the next steps. Thanks!

Comment entered 2024-02-13 11:17:25 by Kline, Bob (NIH/NCI) [C]

Installed on DEV.

https://github.com/NCIOCPL/cdr-admin/commit/fbb20ac3

Comment entered 2024-11-13 10:44:37 by Kline, Bob (NIH/NCI) [C]

Acceptance Criteria

  • CIAT/OCC > General Reports > Document Content Reports > Show CDR Document XML

  • Leave the Selection Method field at the default By document ID

  • Enter 62888 in the CDR ID field

  • Select Most recently created publishable version

  • Click Submit

  • Note the <StandardWording><GlossaryTermRef ...>Cancer</GlossaryTermRef> that forms in the thin, flat cells lining the inside of the esophagus.</StandardWording> content.

  • CIAT/OCC > Translations > Fetch English Summary For Translation

  • Enter 62888 in the Document ID field

  • Enter pub in the Version field

  • Select QA from the Tier picklist

  • Leave the Output field at the default Display (for viewing)

  • Click Submit

  • Confirm that the content noted above is present but without the <StandardWording>...</StandardWording> markup

Attachments
File Name Posted User
image-2024-01-18-15-43-16-704.png 2024-01-18 15:43:17 Kline, Bob (NIH/NCI) [C]
image-2024-01-18-15-45-59-732.png 2024-01-18 15:46:00 Kline, Bob (NIH/NCI) [C]
image-2024-01-18-15-46-35-219.png 2024-01-18 15:46:35 Kline, Bob (NIH/NCI) [C]

Elapsed: 0:00:00.001578