Issue Number | 5313 |
---|---|
Summary | GovDelivery Report displays new summary multiple weeks |
Created | 2023-12-19 08:54:27 |
Issue Type | Bug |
Submitted By | Osei-Poku, William (NIH/NCI) [C] |
Assigned To | Englisch, Volker (NIH/NCI) [C] |
Status | Resolved |
Resolved | 2024-01-25 19:09:18 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.372572 |
The GovDelivery report appears to display new summaries multiple weeks depending on when the summary is made publishable. So far, we have only observed this behavior in new Spanish summaries.
814552 was reported last week and the previous week as a new summary.
!/attachment/ocecdr_252471_GovDeliveryNewSummary1-2.PNG|width=361,height=128,thumbnail!
The GovDelivery report checks if a document’s modification date is within the date range of the previous two publishing events like
start_date <= Document_date <= end_date
Obviously, the end_date of the previous date range will be the start_date of the following date range. A new summary document gets assigned the publishing date of the publishing job – start_date, which means the document gets selected twice with the above selection criteria, once for last weeks end_date and once for this weeks start_date.
The script will need to be modified to fix the selection of the date range to
start_date <= Document_date < end_date
This will exclude the selection of a document for two consecutive weeks.
The following program - which runs as a scheduled job - has been updated:
gov_delivery_reports.py
https://github.com/NCIOCPL/cdr-scheduler/commit/6d10a76
I'm currently running a test publishing job to confirm the fix.
The program changes have been successfully tested on the QA server.
In order to test this ticket one must create a new summary and make it publishable on the same day that the weekly publishing job is running (Note: The issue is/was not limited to Spanish summaries.)
Once the publishing job finished the Gov_Delivery report needs to run which will include the newly published summary. After the Gov_Delivery report ran another weekly publishing event needs to run followed by another run of the Gov_Delivery report. The second Gov_Delivery report including the fix will not display the newly created summary again. The old version displayed the newly published summary on both reports.
Note: After the gov_delivery_reports.py program has been updated, the CDR Scheduler service needs to be restarted.
File Name | Posted | User |
---|---|---|
GovDeliveryNewSummary.PNG | 2023-12-19 08:50:10 | Osei-Poku, William (NIH/NCI) [C] |
GovDeliveryNewSummary1-2.PNG | 2023-12-19 08:53:28 | Osei-Poku, William (NIH/NCI) [C] |
Elapsed: 0:00:00.001686