CDR Tickets

Do you remember which document you were using with the duplicates in the Label Name?

By the way, the report is using DIVs instead of tables.

Do you remember which document you were using with the duplicates in the Label Name?

CDR713967

By the way, the report is using DIVs instead of tables.

The reason there's padding for the table cells in the screenshot is that I hacked the CSS in the browser to add the padding.

It's possible, I suppose, that the duplication of labels is intentional for some reason. If so, that reason isn't obvious. We can check with the users.

You are looking at an old report.  Are you looking on DEV?  This report has been modified with OCECDR-5149 (Pauling) and looks more like this:

I'm looking at PROD.

So I guess this means that only two of the three anomalies still need to be addressed (the duplicate labels and the stray "h" at the end of the report date/time).

Could you point me to the "duplicate labels"?  I may be blind but I'm not seeing any duplication.

The "stray h" seems to be a German thing.  When using 24-hour display we're adding "Uhr" to the display which I though the "h" would indicate in order to distinguish from the 12-hour AM/PM display.  Looks like I was making that up and I can't find that in the ISO standard.

Oh, you are talking about content.  I will leave that up to ~oseipokuw to fix.

Ah, I see. I was assuming that the software was extracting those values from larger strings and just failing to deduplicate the results. I see now that this was a bad assumption, and the unwanted duplication is indeed in the document itself. Yes, you definitely want to reflect the duplication in the QC report so the users can see and fix the problem (that what the QC report is for, after all). Ball's in your court for that one, ~oseipokuw. So that leaves you with one tiny character to remove, ~volker. 🙂

The duplicate Label Names is intentional. There are two "labels" for Cancer in the image.

For my information:

The following filters need to be modified:

• CDR000050.xml - Organization QC Report Filter

• CDR257553.xml - Glossary Term Name with Concept QC Report Filter

• CDR430928.xml - Module: QC Filter Templates

https://github.com/NCIOCPL/cdr-server/commit/399debb

The listed filters have been installed on DEV to remove the extra "h" character.

Looks good. Can be pushed up the tiers.

I ran diff reports on QA confirming that no unexpected changes popped up.  The three filters have been copied to QA, STAGE, and PROD.

Please verify on PROD and close this ticket.

Perfect!