CDR Tickets
| Issue Number | 5179 |
|---|---|
| Summary | Need to revise HP disclaimer text |
| Created | 2022-12-16 11:18:25 |
| Issue Type | Improvement |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2022-12-16 20:12:37 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.334842 |
As we discussed in the CDR Review meeting yesterday, we need to revise the display the text of the link in the HP disclaimer found on all HP pages on Cancer.gov, both English and Spanish. Also, as discussed, since the text of the link is same everywhere, it would be better to update this in the miscellaneous documents rather than in a filter.
Miscellaneous documents:
CDR 733750 (Disclaimer for HP)
CDR 733749 (Disclaimer for HP-Spanish)
We had discussed in the meeting that a PlaceHolder element isn't needed currently and the element could be replaced by an ExternalRef element since we are using different misc. documents for both, the English and the Spanish documents. The description for this ticket doesn't mention the type of change for the disclaimer text. I'm guessing this ticket is meant to address the filter change to remove the code that's replacing the PlaceHolder element with the name="PDQ-DB" since this won't be used anymore once the misc. document has been updated.
The change to the misc. document text itself, i.e. the removal of this particular PlaceHolder doesn't require a filter change unless a new PlaceHolder element is being introduced.
The following filter has been updated to remove the PlaceHolder[name="PDQ-DB] template:
CDR000157 - Vendor Filter: Summary
https://github.com/NCIOCPL/cdr-server/commit/fb18b0f
A publish preview report will ignore the information until the misc. document has been updated.
Thanks for the clarification ~volker It is good to know that removing the placeholder element from the Misc Doc won't cause any problems, and yes, this ticket is for the filter change.
Did you have a chance to look at this ticket, ~oseipokuw?
Hi ~volker Yes, we have already published the changes and reviewed them on Cancer.gov already. Thanks!
Verified!
Please let me know if I should close the ticket.
A diff report on QA revealed no unexpected surprises. The filter has been pushed to both, the STAGE and PROD tier.
The filter changes not to use the PlaceHolder element have been copied to all tiers.
Closing ticket.
| File Name | Posted | User |
|---|---|---|
| hp disclaimer.png | 2022-12-16 11:17:23 | Osei-Poku, William (NIH/NCI) [C] |
Elapsed: 0:00:00.000627