Issue Number | 4758 |
---|---|
Summary | [Glossary] Pub Preview for new GTN error |
Created | 2020-01-13 13:23:43 |
Issue Type | Bug |
Submitted By | Osei-Poku, William (NIH/NCI) [C] |
Assigned To | Englisch, Volker (NIH/NCI) [C] |
Status | Closed |
Resolved | 2020-06-10 15:54:58 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.254924 |
There seems to be a problem with Pub Preview for newly created GTN documents on PROD. The following error message is displayed when you try to generate PP.
"no document to filter."
When a publishable version is created, Pub Preview works.
The fix is not a filter change but a change to the script
PublishPreview.py
Therefore, this ticket needs to be part of our Leibniz release.
I've made the necessary changes on DEV.
~volker Could you please
verify that this change is currently on DEV? I am getting the same error
message as before.
Sample Document 799636
No, the change was not on DEV. I've copied the version I modified to DEV again. However, you are now getting a different error message for this document: "Unable to resolve uri 'CDR0000799635/lastp'"
I assume then that it is because there is no publishable version that
is why I am getting the
"Unable to resove uri" error and that might be because of the changes in
OCECDR-4773 ? This is a problem because we need to be able to retrieve
PP before making the documents publishable so we may have to back out of
the changes in OCECDR-4773, if that is the only way to get PP before
making a document publishable.
The PublishPreview report takes the vendor output and renders it into HTML. We have a rule that only documents that are made publishable and are ready to go to Cancer.gov can get filtered into the vendor output. If you want to revert this rule you're accepting that content that's not publishable will be able to be displayed on Cancer.gov.
We can't prevent non-publishable documents from getting to Cancer.gov and allow PP to display non-publishable documents because the PP report is using the exact same data that is being pushed to Cancer.gov.
The only way around this dilemma that I see at the moment is maybe an additional option for the PP report - a third path through the filters - or a maybe a secondary PP report that does not use the vendor output but then you'd have to maintain two programs doing essentially the same.
I think we should discuss possible solutions for this ticket on Thursday.
We decided to modify the GTC full QC report to serve as pub preview for cases where users have not created a publishable version of the GTC but would like to view pub preview. I will create a ticket to address this in Maxwell.
Verified on DEV. Thanks!
~volker I am getting the "no document to filter" error for a new term 801696. It seems like this error was fixed on DEV.
Unless I'm misreading the comment history for this ticket, the software is doing what it's supposed to do.
You (~oseipokuw) said,
We decided to modify the GTC full QC report to serve as pub preview for cases where users have not created a publishable version of the GTC but would like to view pub preview. I will create a ticket to address this in Maxwell.
So why wouldn't this decision be just as applicable to QA as it was to DEV?
Ah, I see. The discussion above was about the GTC. In this case, it's the GTN which has no publishable version.
The requirement that the GTN be published for PP (unless the URL specifies otherwise) is in the code on production (so the situation you're describing here wasn't "fixed on DEV"). I have modified it at Volker's request. Please test on QA.
Verified on QA. Thanks!
File Name | Posted | User |
---|---|---|
image-2020-06-10-15-07-47-788.png | 2020-06-10 15:07:48 | Kline, Bob (NIH/NCI) [C] |
Elapsed: 0:00:00.001973