CDR Tickets

Issue Number 4757
Summary Summary Fragment Refs not working in Summaries QC reports
Created 2020-01-13 11:26:13
Issue Type Bug
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2020-01-17 12:10:19
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.254901
Description

It appears summary fragment refs are not working in summary QC reports (B/U and RS) on PROD. The following python script error is displayed when you click on a link.

"A problem occurred in a Python script.

D:\cdr\Log\tmpvkhk_rxh.html contains the description of this error.
"
Sample documents with summary fragment refs.
CDR0000269124
CDR0000800325

Comment entered 2020-01-13 16:04:51 by Juthe, Robin (NIH/NCI) [E]

, is this referring to summary fragment refs that point to other summaries (as opposed to those internal to the summary)?

Comment entered 2020-01-13 16:58:58 by Osei-Poku, William (NIH/NCI) [C]

Yes, that was my first reaction when I saw this. I thought it was the one we had reported and discussed already in OCECDR-4676. But it appears to be a new bug after Kepler was released.

Comment entered 2020-01-14 16:44:24 by Englisch, Volker (NIH/NCI) [C]

Which document is supposed to be displayed when clicking the link for a SummaryRef?  Publishable version, last version, or CWD?

Comment entered 2020-01-14 17:39:01 by Englisch, Volker (NIH/NCI) [C]

I've modified the following filter

  • CDR339576: Module: InLine Markup Formatter

The link will open the QC report for the CWD of the linked document.

This is ready to review on DEV.

Comment entered 2020-01-14 18:34:46 by Osei-Poku, William (NIH/NCI) [C]

The links appear to be working for only Patient summaries. The links in the HP summaries take you to the attached page.

Comment entered 2020-01-15 18:15:32 by Englisch, Volker (NIH/NCI) [C]

That's correct, I had only updated the link to patient summaries.  I've added the fix for the HP summaries now.

Please take another look.

Comment entered 2020-01-15 18:42:08 by Osei-Poku, William (NIH/NCI) [C]

Yes, it is working in both Patient and HP summaries now. Thanks!

Comment entered 2020-01-17 12:10:08 by Englisch, Volker (NIH/NCI) [C]

The filter change has been copied to QA and STAGE.

I ran and reviewed a diff report on all summary QC reports and identified the fix as the only change.

Please review on QA and then I will update the filter on PROD.

Comment entered 2020-01-17 13:47:26 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA. Thanks!

Comment entered 2020-01-21 15:31:38 by Englisch, Volker (NIH/NCI) [C]

The following filter change has been copied to PROD

Please verify on PROD and close this ticket.

Comment entered 2020-01-22 09:30:31 by Osei-Poku, William (NIH/NCI) [C]

It doesn't appear to be working. I am getting python script errors for both summary refs and summary fragment refs.

CDR0000062787

Comment entered 2020-01-22 11:05:39 by Englisch, Volker (NIH/NCI) [C]

Sorry about that!  I had copied the correct version but later realized I didn't make the copied version publishable, so I copied the filter again.  At this point, however, I had already changed my git branch and therefore copied the original version instead of the new one.  

It's now fixed and the correct version is on PROD.  Please give it another try.

Comment entered 2020-01-22 11:35:00 by Englisch, Volker (NIH/NCI) [C]

The changes in the branch cdr4757-summary-refs have been merged into the master branch.

Comment entered 2020-01-22 18:57:46 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thank you!

Attachments
File Name Posted User
HP summary frag ref.PNG 2020-01-14 18:34:41 Osei-Poku, William (NIH/NCI) [C]
pythonscript error.PNG 2020-01-22 09:30:28 Osei-Poku, William (NIH/NCI) [C]
summaryfragrefs_prod.PNG 2020-01-13 11:22:07 Osei-Poku, William (NIH/NCI) [C]

Elapsed: 0:00:00.002041