CDR Tickets

Issue Number 4753
Summary [Internal] PubStatus Report Buttons
Created 2019-12-09 17:38:22
Issue Type Improvement
Submitted By Englisch, Volker (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2020-05-13 09:30:21
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.253432
Description

When viewing the PubStatus.py report
https://cdr-qa2.cancer.gov/cgi-bin/cdr/PubStatus.py?id=17748
the header displays the "Report Menu" and the "Admin Menu" buttons.
1. The Report Menu button isn't useful at this point.  A link to the developer menu would make more sense.
2. The Admin Menu button brings you to the guest menu but not the admin menu.

Comment entered 2019-12-09 18:58:49 by Kline, Bob (NIH/NCI) [C]

When you view the report logged in with sufficient privileges (rather than as guest as with the URL you give), the Admin Menu button does indeed take you to the Admin menu. I imagine the most rational change to make (if any) would be to detect that the current session doesn't have sufficient privileges for all the buttons displayed, and prune the button list to reflect that condition. That's not an approach taken anywhere else in the menu system, though, so if we do that here, we might want to consider a broader examination of the menu system, perhaps modifying the Controller class to perform that modified logic globally. I did actually consider whether it would be more appropriate to have a button for the Dev/Admin menu instead of the Reports menu, but (a) this is a report, after all, and (b) the Reports button is what is provided on PROD. We can revisit all these decisions in Leibnitz, though.

Comment entered 2019-12-09 19:17:18 by Englisch, Volker (NIH/NCI) [C]

but (a) this is a report, after all, 

It's possible you can get to this report via the report menu and in that case I would agree with you that the Reports menu makes sense.  In the current case, however, I'm getting the report by going through the Publishing menu.  I had seen these buttons as a way to get back to the parent and the top of the menu branch.  Jumping to a different branch was unexpected.

and (b) the Reports button is what is provided on PROD. 

I don't see any buttons when I look at the PubStatus report on PROD.  We must be getting to this page using different paths.
https://cdr.cancer.gov/cgi-bin/cdr/PubStatus.py?id=17574

Yes, it would be nice to come up with a standard approach across the pages.  Leibniz, here we come. 🙂

Comment entered 2019-12-09 20:07:26 by Kline, Bob (NIH/NCI) [C]

Comment entered 2019-12-10 11:17:52 by Englisch, Volker (NIH/NCI) [C]

This is what you will get when you follow the link I included:

Comment entered 2020-05-13 09:30:21 by Kline, Bob (NIH/NCI) [C]

Buttons modified on DEV (Admin replaced by Developer Menu and Reports Menu removed).

Comment entered 2020-06-24 16:01:36 by Englisch, Volker (NIH/NCI) [C]

Verified on PROD.  Closing ticket.

Attachments
File Name Posted User
image-2019-12-09-20-03-37-300.png 2019-12-09 20:04:13 Kline, Bob (NIH/NCI) [C]
image-2019-12-09-20-06-27-012.png 2019-12-09 20:07:02 Kline, Bob (NIH/NCI) [C]
Screen Shot 2019-12-10 at 11.12.25.png 2019-12-10 11:16:46 Englisch, Volker (NIH/NCI) [C]

Elapsed: 0:00:00.001931