| Issue Number | 4662 |
|---|---|
| Summary | Image markup needs to match Drupal |
| Created | 2019-09-05 17:18:01 |
| Issue Type | Task |
| Submitted By | Burack, Lindsay (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2022-03-23 11:04:37 |
| Resolution | Won't Fix |
| Path | /home/bkline/backups/jira/ocecdr/issue.249377 |
Our migration to Drupal changed the markup on CGOV images, but PDQ images did not get updated. Images coming from the CDR should have markup that matches images coming straight from Drupal.
Tag to wrap all PDQ images with. Note the displays change and the
align-left
<div data-entity-embed-display="view_mode:media.image_display_article_medium" class="embedded-entity align-left">
Looks like a filter change task.
~bkline, Is this something that should be handled before the Python 2.7 tasks?
I would consult with Amy and Lindsay on that priorities question.
What's the part that needs to be modified? I'm seeing two differences:
The PDQ imaged are carrying the Enlarge link. I'm guessing this won't change.
The caption is displayed with a caption-container on the figure element for PDQ while other images use a caption class for a div inside the figure element. I'm guessing this is what needs to be adjusted.
Is that correct, ~buracklb?
Ball's in your court, ~buracklb. 😛
~bkline, ~volker – I'm flattered that you both think I know enough about the classes and containers on CGOV to answer this, but this is not in my wheelhouse. ~arcepe is much better suited to answer this one.
If you can't persuade anyone to clarify/confirm what you need to do, ~volker, go ahead and close this ticket for now.
Closing ticket for now. If needed and requirements are available we can re-open it at a later time.
This ticket, after being closed for about a year, had been reopened nearly a year ago. I still don't really know what needs to be done (or who would know).
This must have been opened automatically when the patch was mistakenly posted to this ticket.
Elapsed: 0:00:00.001597