CDR Tickets

Issue Number 4666
Summary Misaligned Bullets in PDQ Summary on Cancer.gov
Created 2019-09-16 13:17:55
Issue Type Bug
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2019-09-26 11:27:19
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.249796
Description

At least one of the bullets under the "on this page" section of the Childhood Liver Cancer Treatment HP summary (CDR62836) is misaligned with the text.

 

https://www.cancer.gov/types/liver/hp/child-liver-treatment-pdq

 

I thought this might be a data problem with a set of empty tags, but nothing is jumping out at me so I'm sending it to the experts.

Comment entered 2019-09-16 14:45:21 by Kline, Bob (NIH/NCI) [C]

Can you track down where those <br> elements are coming from, ?

Comment entered 2019-09-16 14:56:59 by Kline, Bob (NIH/NCI) [C]

I have a pretty good guess. Looks like there are two blank lines in the SectionTitle for the summary section. Those are being translated into br HTML elements. If you change that title to strip out the two blank lines at the front of the title, , and then hotfix the summary, I'm pretty sure the extra whitespace will go away. Another approach to the problem would be to modify the filters so that the value goes through the XSL/T normalize-space function, . The first approach might be safer, as I'm not sure without further analysis and testing what the normalize-space function does in the face of inline markup.

Comment entered 2019-09-16 15:03:54 by Juthe, Robin (NIH/NCI) [E]

Ah-ha! Thank you. I figured it must be a data problem, but I couldn't spot it. I just removed the line breaks and will work with Crystal and Volker to hot fix. Thanks!

Comment entered 2019-09-16 15:13:12 by Englisch, Volker (NIH/NCI) [C]

I don't think this is a proper use of the SummaryModuleLink.  A SummaryModuleLink is displayed instead of a SummarySection.  Here, however, we're trying to create a SummarySection in the parent document and then add a section from the module.

<SummarySection>
   <Title>Dada</Title>
   <SummaryModuleLink/>
</SummarySection>

I would think the Title element needs to be moved to the module and the entire section containing the module gets replaced with the SummaryModuleLink.

Comment entered 2019-09-16 15:23:30 by Englisch, Volker (NIH/NCI) [C]

Or what Bob says.

Comment entered 2019-09-26 10:50:23 by Englisch, Volker (NIH/NCI) [C]

I believe this issue got resolved, didn't it?  Can it be closed?

Comment entered 2019-09-26 11:27:12 by Juthe, Robin (NIH/NCI) [E]

Yes, it did! Removing the blank lines did the trick. I'll close it.

Attachments
File Name Posted User
Ch Liver Summary.png 2019-09-16 13:17:47 Juthe, Robin (NIH/NCI) [E]

Elapsed: 0:00:00.001456