CDR Tickets

This appears to be yet another defect in ADO/DB. All I had to do was to swap out the database library built with ADO/DB and replace it with the newer one (based on ODBC) that we used for the new Python API written to replace the C++ server and the report works again (on DEV). Here's the patch for Leibnitz:

cgi-bin/cdr/DocumentsModified.py
index 67257c20..55a3ec1e 100644
--- a/Inetpub/wwwroot/cgi-bin/cdr/DocumentsModified.py
+++ b/Inetpub/wwwroot/cgi-bin/cdr/DocumentsModified.py
@@ -8,7 +8,7 @@
 import cgi
 import cdr
 import cdrcgi
-import cdrdb
+from cdrapi import db
 import re
 import time
 import sys
@@ -45,7 +45,7 @@ if request == "Log Out":
 # Connect to the database.
 #----------------------------------------------------------------------
 try:
-    conn = cdrdb.connect("CdrGuest")
+    conn = db.connect(user="CdrGuest")
     cursor = conn.cursor()
 except:
     cdrcgi.bail("Unable to connect to the CDR database")

Since this script has not changed in over two years (and assuming it's used more frequently than ever couple of years and that you would have reported the failures if it hadn't worked before), it seems most likely that a Microsoft patch to ADO/DB (or — less likely — to SQL Server) broke something.

As part of the upgrade to Python 3 the older library based on ADO/DB will have been completely retired, so this is one class of bug we will be leave behind us for good. Now that I think of it, by the time we get to Leibnitz, the Python upgrade will already have happened, so the patch won't be necessary. 🙂

Fixed on DEV.

By the way, ~volker, which way are we going to spell it: Leibnitz or Leibniz? I've seen it both ways, from reliable sources.

Ah, I see we've already got a Leibniz sprint. 🙂

Which sources were that?  Just wondering.

I have to admit that I originally spelled his last name Leibnitz myself but then I went to the German Wikipedia and found some information regarding his spelling.  His father's name was Leibnütz , his latin name was Leibnitius and in the French literature his name was spelled Leibnitz.  However, based on his signature on letters he wrote he apparently decided in 1671 to use the spelling Leibniz which is what we will use.

https://www.maths.tcd.ie/pub/HistMath/People/Leibniz/RouseBall/RB_Leibnitz.html, z.B.

Note that this one has both spellings right there in the URL! 🙂

Verified on DEV. Thanks!

Verified on QA. Thanks!