CDR Tickets

Issue Number 4484
Summary [Summaries] Macro to Search for Comments by Attribute
Created 2018-05-25 15:39:42
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2018-06-13 17:05:09
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.226723
Description

We would like to add a macro to search for comments with a particular attribute.

The possible attributes include: Advisory Board, Internal, External, and Permanent.

This should have a toolbar icon (similar to the Find Next Revision Markup macro).

The window should remain visible with selections preserved as you are navigating from comment to comment. Thanks!

Comment entered 2018-06-08 10:02:13 by Kline, Bob (NIH/NCI) [C]

We have had similar requests in the past for modeless dialog boxes, and after discussion we came to the conclusion that we would use modal dialog boxes instead, because the former are more expensive to implement, and are somewhat riskier (if they're obscured they can be forgotten, and it's unclear what happens when another document window is made the active window). Nevertheless, I'm willing to give this (and I think there's one other such request in this release) a try and see how it works out if that's what you really want. Not confident about the story points estimate. :-)

Comment entered 2018-06-08 10:21:22 by Kline, Bob (NIH/NCI) [C]

Replying to my own comment: It's possible that you didn't mean to imply that you want a modeless dialog box here. It's equally possible that you meant a modal dialog box which stays open while you navigate from comment to comment, and when you need to do something with the document you close the dialog box. This would be easier and safer to implement, and it would be possible for your selections to be "sticky" (that is, preserved when you next open the dialog box from the choices you had made the previous time during the same session). , please let me know which interpretation you had in mind.

Comment entered 2018-06-08 10:48:21 by Englisch, Volker (NIH/NCI) [C]

The way I understand the request, this should be similar to the Find and Replace dialog box for elements (Element tab) except that in addition to searching for an element you should also be able to select one of the attributes.

Comment entered 2018-06-08 11:03:07 by Englisch, Volker (NIH/NCI) [C]

Did you know you can already search for comments with a specific attribute?

  • Open the Search and Replace window (CTRL-F)

  • Click the Element tab

  • In the Find: entry box enter: <Comment audience="External">

  • Click Find

Comment entered 2018-06-08 12:42:56 by Juthe, Robin (NIH/NCI) [E]

Interesting. I didn't know we could edit the find box in the find & replace query for elements. Good to know. Let me run this solution past our group to see if it's adequate. Looks like we can also search for comments by source by entering <Comment source="advisory-board"> in the Find box.

Comment entered 2018-06-08 12:53:53 by Englisch, Volker (NIH/NCI) [C]

This is 's ticket so I'm not saying this should be the solution. However, when I looked at the ticket and I found out this type of searching is possible I wondered if I was the only one who didn't know about it. It seems to me that you could already achieve most of what you're looking for using the standard Find and Replace.

Comment entered 2018-06-12 11:40:17 by Kline, Bob (NIH/NCI) [C]

: did your group have any feedback?

Comment entered 2018-06-12 12:30:03 by Juthe, Robin (NIH/NCI) [E]

We're planning to discuss this in a meeting tomorrow.

Comment entered 2018-06-13 14:49:20 by Juthe, Robin (NIH/NCI) [E]

We discussed this today and we would like to proceed with our request to develop a macro for this purpose. While the solution above does work, it was decided this was too difficult to remember/enter consistently when needed, so a macro would be more useful and user-friendly. We also talked about how the macro should work in terms of modal/modeless, and if I understand these terms correctly, we would still like for it to be a modeless dialog box. Bottom line is that, as I said above, the window should remain visible with selections preserved as you are navigating from comment to comment. Thanks!

Comment entered 2018-06-13 17:05:09 by Kline, Bob (NIH/NCI) [C]

The new macro and button have been installed on DEV (button is directly to the left of "Itemized List" button).

https://github.com/NCIOCPL/cdr-client/commit/df4cf12

Comment entered 2018-06-21 15:03:23 by Juthe, Robin (NIH/NCI) [E]

This looks good on DEV. Thanks!

Comment entered 2018-07-18 15:53:58 by Beckwith, Margaret (NIH/NCI) [E]

QA verified.

Elapsed: 0:00:00.001589