| Issue Number | 4483 |
|---|---|
| Summary | [Summaries] Display of Comment Attributes in XMetaL |
| Created | 2018-05-25 15:37:22 |
| Issue Type | Improvement |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2018-06-14 17:37:42 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.226722 |
We would like to make it easier to identify which comments have been assigned certain attributes (e.g., internal, external, Advisory Board, and permanent) without having to click within the comment element and view the attribute inspector.
One possible solution we discussed is to display text within the comment field indicating which of these attributes have been assigned. This text should only appear in XMetaL, and not be displayed in the QC reports.
For internal comments, please add "(Internal)" at the end of the
comment string.
For external comments, please add "(External)" at the end of the comment
string.
For AB comments, please add "AB-Comment:" at the beginning of the
comment element (as is done in the QC reports).
For permanent comments, please add "Permanent-Comment:" at the beginning
of the comment element (as is done in the QC reports)
Thank you!
For internal comments, please add "(Internal)" at the end of the comment string.
For external comments, please add "(External)" at the end of the comment string.
There exist comments without either the Internal or External audience specified. How would you like these to be displayed? Options are empty parenthesis "()" or nothing at all.
For AB comments, please add "AB-Comment:" at the beginning of the comment element (as is done in the QC reports).
For permanent comments, please add "Permanent-Comment:" at the beginning of the comment element
Permanent and advisory-board comments aren't exclusive and you could have comments that are both, permanent as well as advisory-board comments. What type of string would you like to display in this situation?
Let's go with nothing at all for those comments. There should be a relatively small number of them given that the insert comment macro includes an internal attribute by default.
I think this would be an edge case 🙂, but let's go with "Permanent-AB-Comment:" for these comments.
Are we making the same changes for the ResponseToComment elements or can we assume a response to a Permanent-AB-Comment would be a Permanent-AB-Response itself?
The CSS changes for the Comment element are ready on DEV.
The CSS for the in-line comments has been adjusted as requested.
Please let me know if we also want to make changes to the
ResponseToComment elements.
The following file has been modified:
Summary.css
Local repository: [ising 1dd1408]
Sorry, just catching up on JIRA comments - yes, please make the same changes to the ResponseToComment elements. We can't really make that assumption since each comment/response has its own set of attributes and we're using this display of the attributes in XMetaL to make sure we've assigned them appropriately. Thanks.
I made the additional changes to the ResponseToComment element as well:
Summary.css
This looks good on DEV. Thanks!
QA verified.
Comment attributes are now displayed on PROD.
Closing ticket.
Elapsed: 0:00:00.001479