Issue Number | 4148 |
---|---|
Summary | [Summaries] QC Reports - Advisory Board comments display when copied into Word |
Created | 2016-09-01 09:41:53 |
Issue Type | Bug |
Submitted By | Juthe, Robin (NIH/NCI) [E] |
Assigned To | Englisch, Volker (NIH/NCI) [C] |
Status | Closed |
Resolved | 2017-03-17 16:37:36 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.193345 |
On the QC Report interface, when we select that we'd like to see "External comments (excluding Advisory Board comments)", the QC report correctly displays external comments that are not marked as having the Advisory Board source. However, when this QC report is copied and pasted from the browser into MS Word, the External Advisory Board comments are shown.
This again is a browser specific problem. I was able to convert a document with hidden Advisory Board comments to Word correctly when using Chrome or Firefox. Only when using our default IE browser will the hidden advisory board comments be visible after the HTML-2-Word (a,k.a. copy/paste) conversion.
The work-around to this problem suggested on the Internet is to remove the comments that are hidden using JavaScript prior to copying the text.
I am wondering if this ticket may have a similar solution to the problem as the linked ticket (inheritance of CSS styles).
I was discussing this issue with Mark and he figured out what the
problem is:
Word doesn't handle multiple classes for a single element - in our case
a span element! If one class defines to make text blue and
another to underline the same text, only the first class specified is
honored by Word. If both styles are included in a single class Word
handles this correctly. This means the solution to this particular
problem would be to ensure the class responsible for hiding the text is
specified first.
I can think of two possible solutions but need to do a little more digging now that I know what our goal is.
I've implemented a simple solution but it's not a perfect
solution.
Since Word doesn't "see" the class name none unless it's the
first name in a list of class names I'm removing all class names and
replacing it with the one class name none once the QC report is
loaded.
Possible problems:
If we want to be able to toggle between displaying Editorial and Advisory board comments this solution will not work
If we need to be able and toggle comments we could re-order the classes and list none first but keeping all other classes
If we end up using the span element with the class="none" in other places we'll need to be more specific in identifying which elements should be displayed or not and we may need to introduce ID values for the span elements.
Bob and I had talked about other solutions, i.e. creating one single class instead of using multiple classes to define the styles or adding another filter to handle the change instead of using JScript.
The following filter has been modified (trunk sandbox):
CDR000079 - Health Professional Summary Report
Which other reports are pasted into Word that may need to be modified?
~juther, these filter changes are on DEV and ready to be moved up the tiers if the change fixes your problem.
Volker, I'm not seeing these changes on DEV. The AB comments are still showing up when I copy/paste a report that doesn't include them into Word.
Same thing. I'm using our favorite Bugzilla status: Works for me!
Let's look at this report together in the morning. I used CDR62902 as a sample document on DEV and ran the QC report with default options.
I now see that I had a question added to one of my comments:
Which other reports are pasted into Word that may need to be modified?
I had only modified the RLSO HP report but not the BU HP report. The following filter has now been updated on DEV:
CDR000153 - Health Professional Summary Report-Bold/Underline
Will we need to update the patient reports as well?
Verified on DEV. I don't think we need to update the patient QC reports since we don't use AB comments in those summaries.
The filters have been updated on QA and STAGE. Please double-check before copying the changes to PROD.
Verified on STAGE.
The following filters have been updated on PROD:
R14859: Health Professional Summary Report (CDR000079)
R14859: Health Professional Summary Report-Bold/Underline (CDR000153)
Please verify on PROD and close this ticket.
Verified on PROD.
Elapsed: 0:00:00.001312