CDR Tickets

Issue Number 4149
Summary [Summaries] Markup within QC Report TOC
Created 2016-09-01 09:53:46
Issue Type Bug
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2017-01-19 11:28:59
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.193348
Description

There are some issues with the display of markup within the TOC in summary QC reports (I'm not talking about the TOC macro).

1. In the B/U QC report, inserted section headings appear just like regular text. Could these be underlined so we can easily tell them apart? The Word macro should preserve this underlining (this relates to #2, below).

2. In the RLSO QC report, inserted section headings appear in red in the QC report and when copied/pasted into Word. However, once the Word macro is run, the red is converted to black and inserted text appears just like regular text.

Comment entered 2016-09-07 18:27:22 by Englisch, Volker (NIH/NCI) [C]

In the B/U QC report, inserted section headings appear just like regular text. Could these be underlined so we can easily tell them apart? The Word macro should preserve this underlining (this relates to #2, below).

I would need to see an example as I wasn't able to reproduce the behavior with the default options.
On DEV, I added insertion text and ran the BU and RS reports - the markup appears as expected. Obviously, since the headings are already bolded the insertion can only be identified because they are underlined.
I then copied the QC report output into Word and - again - the markup shows as expected.

Comment entered 2016-09-07 18:33:31 by Englisch, Volker (NIH/NCI) [C]

In the RLSO QC report, inserted section headings appear in red in the QC report and when copied/pasted into Word. However, once the Word macro is run, the red is converted to black and inserted text appears just like regular text.

I have the suspicion you're experiencing the same problem that Bonnie saw. I was running your macro and the red color in the insertion markup was preserved.
Could you please try again by running the Macro_RJ from the Developer menu directly? It is possible your button is still linked to an old version of your macro. That's what was going on when Bonnie reported the problem.

Comment entered 2016-09-12 12:14:15 by Juthe, Robin (NIH/NCI) [E]

Re #1, I should have been more clear. I was referring to proposed insertions, not approved. Proposed insertions look just like the rest of the surrounding text in the TOC.

Victoria reported the second issue, so I'll ask her to try running her macro from the developer menu as you suggest and see if that resolves the problem.

Comment entered 2016-09-12 12:22:10 by Englisch, Volker (NIH/NCI) [C]

If Victoria's problem is resolved by using the macro from the developer menu all we'll have to do is to re-link her button to the correct macro.
I don't want Victoria to think she couldn't use the buttons anymore for running the macros.

Comment entered 2017-01-17 17:12:27 by Englisch, Volker (NIH/NCI) [C]

I've adjusted the styles for the proposed insertions in order to display the inserted text in headings bold and underlined. The following filter has been updated:

  • R14526: CDR0000380956 (Module: STYLE BU Insertion Deletion)

Item #1 is ready for review on DEV.

Comment entered 2017-01-17 18:05:47 by Englisch, Volker (NIH/NCI) [C]

In the RLSO QC report, inserted section headings appear in red in the QC report and when copied/pasted into Word. However, once the Word macro is run, the red is converted to black and inserted text appears just like regular text.

We're using a macro to convert the TOC entries into plain text from the URLs created in the QC report. Links are typically displayed in blue. Therefore, the links are removed from each list item and the text is set to the default color - black.
We could just remove the links without changing the color of the text and leave it blue along with the marked-up text colors red and green. This would be a quick solution.
The other option would be to keep the color for the insertion/deletion/proposed text and reset all other text to the default text color. This option would require more work and a bit more testing.

Which of the two options would be the preference of changes?

Comment entered 2017-01-18 16:12:24 by Juthe, Robin (NIH/NCI) [E]

We'd like to go with the first option - keeping the original text colors, including red/green and blue in the TOC.

Item #1 looks good on DEV. Thanks!

Comment entered 2017-01-19 11:28:47 by Englisch, Volker (NIH/NCI) [C]

We'd like to go with the first option - keeping the original text colors, including red/green and blue in the TOC.

Excellent choice! :-)

I've updated the Word Macro accordingly. Please copy the macro file from the network at

L:\OCPL\_Cross\CDR\WordStartup\CDR_Macros.dotm

to your workstation at

C:\CDR\WordStartup

Close Word and restart to test the changes.

Comment entered 2017-01-19 11:42:09 by Englisch, Volker (NIH/NCI) [C]

The change to the macro file isn't release dependent but I'm saving a current copy to subversion anyway:

  • R14543: CDR_Macros.dotm

Comment entered 2017-01-31 16:34:52 by Juthe, Robin (NIH/NCI) [E]

I verified these macro changes. All of the colors remain in the TOC now. Thanks, Volker.

Comment entered 2017-03-02 13:19:47 by Juthe, Robin (NIH/NCI) [E]

Verified on QA.

Elapsed: 0:00:00.001344