EBMS Tickets

This was trickier than you might think, as now the software cannot no longer simply index into the front of a fixed array of decision options common to all the queues, with two extra options tacked on at the end of the array for one of those queues (review from full text). which means that the position of any given decision in the array now varies depending on the queue. So I've done a LOT of testing of the page to make sure the way I've had to rewrite all the decision management code didn't break anything, and the users will want to do the same.

I assumed the omission of the "None" button for the full text review queue was just an oversight. You surely don't want the user to be unable to back out a mouse click made by mistake without having to start the review page all over. 😛

Correct. Good catch though and I am guessing users might make this mistake again when discussing review decisions since None is not really a review decision but rather a change we need to get used to now that we are using radio buttons.

I have done a good amount of testing on the Librarian queue page and the decision button order change does not seem to have altered anything else on the page. The queue and all its features and nav are working as expected. Correct decisions are being recorded and retained on the page when navigating back and forth from queue using the different features one the page.

However, I did notice that the Download Full Text button is not working. This is a button that only appears for citations with a passed board manger review state awaiting full text retrieval which is not a common occurrence for me to see in my queue. Today is the first time I have seen this button and opportunity to notice it does not work. So I don't know if this bug is a result of the changes made for this ticket or if it was just not found doing testing so far in the other review queues.

To see the button in the Librarian Queue, filter queue by cancer genetics board, sort by core journals and opt to display 25 citations per page. Citation #11

Well, this is interesting. When I read your repro instructions I thought to myself, "now that's how good repro instructions are supposed to look! All the rest of you testers out there, read and learn how you do it." And that's still absolutely true. There's just one tiny problem. You didn't actually say what "is not working" means. I followed the instructions, and I did indeed see the button. But when I clicked on it, it did exactly what I was expecting it to do (open the PDF in my browser). So kudos for your very clear description of the steps you took, and I know the last thing a user wants to hear is "works for me" from the developer, but I'm afraid we're going to have to dig deeper to find out why whatever's happening for you is happening (and what that is). 😉

I think maybe my brain is fried from all this testing 🙂

Initially I was getting a page not found error that I reproduced several times so maybe this was just a server/internet hiccup.

The button does seem to work fine now in erc. I logged out and back in with a fresh browser and the button took me to the pdf straight away. However, I did make a new discovery. The pdf does not open in a new window and leaves users without a way to get back to the queue without using the browser back button. This may need to be a new ticket though. Let me know if so I'll add it.

Yes, new ticket, please.

done

Current testing status:

Looks good on the Librarian queue and waiting for others to test the two BM queues.

Librarian Queue verified on ebms4

Verified on ebms4.