EBMS Tickets

Issue Number 697
Summary Article Statistics Reports - Articles Rejected During Review of Abstract error with citations included/excluded
Created 2023-01-11 18:55:47
Issue Type Bug
Submitted By Boggess, Cynthia (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2023-01-12 06:37:23
Resolution Fixed
Path /home/bkline/backups/jira/oceebms/issue.336179
Description

The Articles Rejected During Review of Abstract report generated in Prod and EBMS4 are very different. There are citations that are included on one but not the other and citations that are excluded on one and not the other. Try running the report using board = Cancer Genetics, review cycle = December 2022

The first 10 citations listed in the report on EMBS4 are not included in the same report generated in Prod. I noticed that these 10 all seem to have multiple review cycles. And are not rejected by a board manager for topics with December review cycle (I am having to assume the review cycle from the date the decision was made because review cycle is not indicated for each topic in the new version of EBMS).

The other citations in the list either included or excluded from either EBMS4/Prod do not seem to have a pattern that I can identify so far. 

Note: when the report is generated using board = cancer genetics and decision date range = 9/15/22 -9/30/22, the two reports are seem more similar but still have discrepancies. 

See attached spreadsheet. I copied all the ebmsids and sorted them. There is a sheet for both board & review cycle and board & date decision assigned.

ArticlesRejected BM.xlsx

Comment entered 2023-01-12 06:37:23 by Kline, Bob (NIH/NCI) [C]

There was a single bug in some common code behind all the queries in this set of reports (a table-join restricting clause had been left out) which was responsible for all of the bugs in your most recently filed tickets. Again, I had to go back to September, since although the announcement to start testing didn't go out until a couple of weeks later Victoria had asked me to prepare the data for UAT in the middle of December, so it's trickier to compare the new site with PROD for that month than for the preceding months. I modified the sort order for the per-article flavors of this one to make it easier to compare with PROD. Again, thanks for being so thorough! 😉

Comment entered 2023-01-12 12:24:50 by Boggess, Cynthia (NIH/NCI) [C]

The modification to the sort order made it super easy to compare the reports! Thanks for that!

OK in erc the data in this report is matching up with prod.

You mention above that you found a bug in all the queries for this set of reports. I was prepared to enter tickets for 3 other reports that I was seeing discrepancies in yesterday, but I checked them in erc just now and their data are matching with prod. The bug you identified seems to have corrected these discrepancies as well.

Once these changes are deployed to ebms4, I'll take a look at the entire set of reports again to verified we are all good.

Comment entered 2023-01-18 12:05:01 by Boggess, Cynthia (NIH/NCI) [C]

verified on ebms4

Attachments
File Name Posted User
ArticlesRejected BM.xlsx 2023-01-11 18:55:33 Boggess, Cynthia (NIH/NCI) [C]

Elapsed: 0:00:00.000853