EBMS Tickets

Issue Number 397
Summary [Travel] Number of Hotel Nights
Created 2016-09-02 15:58:32
Issue Type New Feature
Submitted By Shields, Victoria (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2016-09-09 13:54:13
Resolution Fixed
Path /home/bkline/backups/jira/oceebms/issue.193470
Description

On the Reimbursement Request Form, under Hotel, we'd like to add an additional field so the member can indicate the number of nights he/she stayed in the hotel. We thought when a person checked either "NCI paid for my hotel" or "I paid for my hotel," a field could appear under that sentence that would say, "Indicate the number of nights stayed" with a box for the user to add the number. Or instead of a free text box for the number, there could be a drop-down box and the user could pick the number (1, 2, or 3). This would be a required field if either of the two fields (NCI paid for my hotel OR I paid for my hotel) is chosen.

Comment entered 2016-09-07 18:41:50 by Shields, Victoria (NIH/NCI) [E]

This information should also appear in the e-mail that the support staff get when members submit their travel expenses.

Comment entered 2016-09-09 13:54:13 by Kline, Bob (NIH/NCI) [C]

Ready for testing on DEV. Let me know which email address(es) you want me to plug in for testing the request notifications.

Comment entered 2016-09-23 09:52:25 by Kline, Bob (NIH/NCI) [C]

Note to self: requires manual deployment step for installing new field (https://ebms.nci.nih.gov/node/2/webform).

Comment entered 2016-09-23 11:27:15 by Kline, Bob (NIH/NCI) [C]

Note to users: in theory there is support for hiding the new field conditionally (as described in the original request), but this support is broken, so the field will always be visible (but only required under the appropriate conditions).

Comment entered 2016-10-04 17:33:26 by Shields, Victoria (NIH/NCI) [E]

Two comments:

1. Please update the text that appears under the number of nights field to say, "Indicate the number of nights stayed in a hotel at NCI's expense.

2. When you submit the form and check either "NCI paid for my hotel" or "I paid for my hotel" but do not select the number of nights, the form (correctly) gives you an error message saying you need to enter the number of nights stayed, but it doesn't make the field red (so it will stand out) like it does with other missed fields.

Comment entered 2016-10-04 17:59:33 by Kline, Bob (NIH/NCI) [C]

Both changes made on DEV and QA.

Comment entered 2016-10-04 18:23:11 by Shields, Victoria (NIH/NCI) [E]

Verified on QA.

Comment entered 2017-04-13 11:48:58 by Shields, Victoria (NIH/NCI) [E]

Verified on PROD.

Elapsed: 0:00:00.000606