EBMS Tickets

Issue Number 28
Summary [Queue] My Topics and Other Topics
Created 2013-09-17 10:13:28
Issue Type Bug
Submitted By Shields, Victoria (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2013-12-23 16:08:08
Resolution Fixed
Path /home/bkline/backups/jira/oceebms/issue.113315
Description

TIR #2207 entered 2012-12-18 by Victoria Shields

Rick Manrow and Deborah Price review (as the "NCI Reviewer" at the abstract review level) specific citation topics for the Adult Treatment Board, so when they go to their "Sort My Queue" page, "Adult Treatment" should be the default and they should only see the citations assigned to their topics.

Sharon Quint-Kasner's "Sort My Queue" page correctly defaults to the Pediatric Treatment Board citations, but she also reviews certain adult treatment topics, so if she chooses "Adult Treatment," she should see her topics.

The topics to which each person is assigned is in the current CiteMS.

Shields, Victoria (NIH/NCI) [E]No presence information (3/28/2013 11:24 AM): Some of the other board managers are seeing an "Other Topics" list at the end of their topics lists in their queues. This separation (of "My Topics" and "Other Topics") is only needed for reviewers of adult treatment topics (and it works correctly for those reviewers). The other board managers should each have one single list of topics.
Tanguturi, Sridhar (NIH/NCI) [C]No presence information (3/13/2013 5:07 PM):
Tanguturi, Sridhar (NIH/NCI) [C]No presence information (3/13/2013 5:05 PM): Moving this to Client Review
Young, Dan (NIH/NCI) [C]No presence information (3/13/2013 4:26 PM):
Young, Dan (NIH/NCI) [C]No presence information (3/13/2013 2:52 PM):
Tanguturi, Sridhar (NIH/NCI) [C]No presence information (3/12/2013 3:29 PM): When SHARON QUINT-KASNER filter by Adult Treatment and she is not seeing any decision check box in her queue.

eg:
PMID: 23099483
CMS ID: 278409
Young, Dan (NIH/NCI) [C]No presence information (3/12/2013 11:39 AM):
Young, Dan (NIH/NCI) [C]No presence information (3/8/2013 2:13 PM):
Young, Dan (NIH/NCI) [C]No presence information (3/6/2013 7:06 PM): It should be doable for users such as Rick and Deb, but what about Sharon? She's assigned the entire board, but I don't believe she's assigned a specific set of topics that excludes those given to the other users. I suppose the queue can exclude topics assigned to another user (if assigned topics are exclusive to each user), but that's a little more work. I'll talk it over internally tomorrow morning, thanks for the update.
Shields, Victoria (NIH/NCI) [E]No presence information (3/6/2013 4:18 PM): Rick and Deb's queues are defaulting to "adult treatment" and Sharon is able to choose "adult treatment" and all three are albe to review (i.e., choose) citations associated with their topics, so this is working now.

However, each of them sees all of the adult topics in their queues rather than just their own topics, which will make it difficult for them to choose their topics and to see when their queues are empty. Can their queues be limited to just the topics they are assigned to review?
Tanguturi, Sridhar (NIH/NCI) [C]No presence information (2/21/2013 3:40 PM): Reassigning back to Client Review.

Tanguturi, Sridhar (NIH/NCI) [C]No presence information (2/19/2013 12:25 PM): Verified and issue fixed in QA.
Young, Dan (NIH/NCI) [C]No presence information (2/15/2013 2:46 PM):
Young, Dan (NIH/NCI) [C]No presence information (2/15/2013 1:17 PM):
Tanguturi, Sridhar (NIH/NCI) [C]No presence information (2/4/2013 4:52 PM): Dan, i can reproduce this issue in QA. Issue was not fixed.

Young, Dan (NIH/NCI) [C]No presence information (2/4/2013 1:23 PM):
Young, Dan (NIH/NCI) [C]No presence information (1/21/2013 3:09 PM):
Young, Dan (NIH/NCI) [C]No presence information (1/21/2013 3:05 PM): Now limits the visible pass/reject options to non-librarian users with either the board or topics attached to their account.
Young, Dan (NIH/NCI) [C]No presence information (1/21/2013 12:27 PM):
Kline, Bob (NIH/NCI) [C]No presence information (12/18/2012 10:10 PM): > "... would need some database support that we don't currently have." That's not really true. There is an nci_reviewer column in the ebms_topic table, and that's where you'd need to look. Rick and Deborah are not board members, board managers, nor librarians, which is why you didn't see anything about them in the stories for landing pages and queues. We can talk more tomorrow about how you'd construct their queues.

Kline, Bob (NIH/NCI) [C]No presence information (12/18/2012 9:42 PM): This would hit your pages, Dan, and would need some database support that we don't currently have.

Shields, Victoria (NIH/NCI) [E]No presence information (12/18/2012 6:05 PM):

Comment entered 2013-12-23 15:27:46 by Kline, Bob (NIH/NCI) [C]

Here's a more readable reconstruction of the original request and subsequent comments (with the dross removed and the comments in order):

ORIGINAL REQUEST 2012-12-18
------------------------------------------------------------------------------------
Rick Manrow and Deborah Price review (as the "NCI Reviewer" at the abstract review level) specific citation topics for the Adult Treatment Board, so when they go to their "Sort My Queue" page, "Adult Treatment" should be the default and they should only see the citations assigned to their topics.

Sharon Quint-Kasner's "Sort My Queue" page correctly defaults to the Pediatric Treatment Board citations, but she also reviews certain adult treatment topics, so if she chooses "Adult Treatment," she should see her topics.

The topics to which each person is assigned is in the current CiteMS.

BOB 2012-12-18 21:42
------------------------------------------------------------------------------------
This would hit your pages, Dan, and would need some database support that we don't currently have.

BOB 2012-12-18 22:10
------------------------------------------------------------------------------------
"... would need some database support that we don't currently have."

That's not really true. There is an nci_reviewer column in the ebms_topic table, and that's where you'd need to look. Rick and Deborah are not board members, board managers, nor librarians, which is why you didn't see anything about them in the stories for landing pages and queues. We can talk more tomorrow about how you'd construct their queues.

DAN 2013-01-21 15:05
------------------------------------------------------------------------------------
Now limits the visible pass/reject options to non-librarian users with either the board or topics attached to their account.

SRIDHAR 2013-02-04 16:52
------------------------------------------------------------------------------------
Dan, i can reproduce this issue in QA. Issue was not fixed.

SRIDHAR 2013-02-19 12:25
------------------------------------------------------------------------------------
Verified and issue fixed in QA.

SRIDHAR: 2013-02-21 15:40
------------------------------------------------------------------------------------
Reassigning back to Client Review.

VICTORIA 2013-03-06 16:18
------------------------------------------------------------------------------------
Rick and Deb's queues are defaulting to "adult treatment" and Sharon is able to choose "adult treatment" and all three are albe to review (i.e., choose) citations associated with their topics, so this is working now.

However, each of them sees all of the adult topics in their queues rather than just their own topics, which will make it difficult for them to choose their topics and to see when their queues are empty. Can their queues be limited to just the topics they are assigned to review?

DAN 2013-03-06 19:06
------------------------------------------------------------------------------------
It should be doable for users such as Rick and Deb, but what about Sharon? She's assigned the entire board, but I don't believe she's assigned a specific set of topics that excludes those given to the other users. I suppose the queue can exclude topics assigned to another user (if assigned topics are exclusive to each user), but that's a little more work. I'll talk it over internally tomorrow morning, thanks for the update.

SRIDHAR 2013-03-12 15:29
------------------------------------------------------------------------------------
When SHARON QUINT-KASNER filter by Adult Treatment and she is not seeing any decision check box in her queue.

eg:
PMID: 23099483
CMS ID: 278409

SRIDHAR 2013-03-13 17:05
------------------------------------------------------------------------------------
Moving this to Client Review

VICTORIA 2013-03-28 11:24
------------------------------------------------------------------------------------
Some of the other board managers are seeing an "Other Topics" list at the end of their topics lists in their queues. This separation (of "My Topics" and "Other Topics") is only needed for reviewers of adult treatment topics (and it works correctly for those reviewers). The other board managers should each have one single list of topics.

Comment entered 2013-12-23 16:08:08 by Kline, Bob (NIH/NCI) [C]

Implemented on DEV. Ready for user review.

  • R12202 trunk/ebms/ebms.nci.nih.gov/modules/custom/ebms/citations.inc

Comment entered 2014-01-06 00:52:48 by Kline, Bob (NIH/NCI) [C]

Promoted to QA.

Comment entered 2014-01-17 12:47:22 by Juthe, Robin (NIH/NCI) [E]

Verified on QA.

Comment entered 2014-02-19 15:06:20 by Juthe, Robin (NIH/NCI) [E]

Verified on production.

Elapsed: 0:00:00.000573