EBMS Tickets

Issue Number 127
Summary [Reports] New Report - Responses By Reviewer
Created 2013-12-06 16:54:21
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2014-01-10 15:51:57
Resolution Fixed
Path /home/bkline/backups/jira/oceebms/issue.115799
Description

We'd like to create a new report that will help us see who is and is not completing literature surveillance reviews. Here are the specs.

Responses by Reviewer Report

Select 1 Board.* (required)
Select 1 or more topics. (optional)
Select 1 or more reviewers. (optional)
Select 1 or more review cycles. (optional)
Enter date range. (optional) – this refers to the date packets were created.

The columns of the report should be (left to right):

Packet Name
Reviewer
Assigned
Completed
Not Completed

Assigned, Completed, and Not Completed refer to the number of reviews they were assigned in that packet, the number of reviews they completed, and the number of reviews they did not complete. We understand that the number of completed and uncompleted reviews may not always add up to the number assigned if articles have been removed from packets after they were originally posted.

Please sort the report by packet name by default. Ideally, both the Packet Name and Reviewer columns would be sortable.

Comment entered 2013-12-13 09:46:32 by Kline, Bob (NIH/NCI) [C]

So if I assign three articles to Joe in a packet, then mark one of the articles as dropped, and Joe reviews the other two, that packet should show up on this report?

Comment entered 2013-12-13 09:48:55 by Kline, Bob (NIH/NCI) [C]

Never mind - I'm getting my reports mixed up. :-)

Comment entered 2013-12-13 15:07:10 by Kline, Bob (NIH/NCI) [C]

Are you aware that packets aren't tied to a cycle in the EBMS? We could do some calculations to match up packets created within a certain date range with the date range implied by the start date tied to a cycle and the start date of the following cycle, but that seems like a convoluted way to do what the date range fields we've already got on the form are doing in a much more straightforward way. Do we really need a filter by cycle for this report?

Comment entered 2013-12-13 15:13:50 by Juthe, Robin (NIH/NCI) [E]

Yes, that's a good point. It doesn't make sense to have cycles on this report since the cycles are tied to individual articles rather than the packet. Let's remove the cycles and keep the date range fields (referring to the date the packet was created). Thanks.

Comment entered 2013-12-13 15:36:43 by Kline, Bob (NIH/NCI) [C]

I'm going to resurrect a version of my first question: should I ignore dropped articles when calculating the "Not Completed" column (but include dropped articles for the "Completed" column)?

Comment entered 2013-12-13 15:50:23 by Kline, Bob (NIH/NCI) [C]

Or another possible approach to this report would be to completely ignore dropped articles (and packets which consist entirely of dropped articles). Would that be reasonable?

Comment entered 2013-12-13 17:48:10 by Kline, Bob (NIH/NCI) [C]

I went ahead and implemented the report on DEV, counting as "COMPLETED" all the articles in the packet that the board member reviewed, including those which had been subsequently dropped, and ignoring dropped articles when computing the "NOT COMPLETED" column. Ready for user testing.

Comment entered 2014-01-03 17:27:21 by Juthe, Robin (NIH/NCI) [E]

That logic makes sense to me. Thanks.

Comment entered 2014-01-06 00:46:51 by Kline, Bob (NIH/NCI) [C]

Promoted to QA.

Comment entered 2014-01-08 13:56:16 by Juthe, Robin (NIH/NCI) [E]

Please add a RESET button to the left of the SUBMIT button. The primary action (triggered by hitting enter) should be to submit the report.

Comment entered 2014-01-08 14:37:13 by Kline, Bob (NIH/NCI) [C]

I can either put the RESET button on the left, or I can have the SUBMIT button be the default action, but not both.

Comment entered 2014-01-09 13:16:42 by Juthe, Robin (NIH/NCI) [E]

OK. Please add the RESET button on the left. This will be consistent with other reports. Thanks.

Comment entered 2014-01-09 13:23:03 by Juthe, Robin (NIH/NCI) [E]

Would it be possible to sort the report output by the date the packet was created (most recent date on top) by default rather than the packet name? Thanks.

Comment entered 2014-01-09 13:25:41 by Juthe, Robin (NIH/NCI) [E]

Please change the mouseover for the date fields to "Assigned date (defaults to no start date)" and "Assigned date (defaults to no end date)".

Comment entered 2014-01-10 09:26:58 by Kline, Bob (NIH/NCI) [C]

Would it be possible to sort the report output by the date the packet was created (most recent date on top) by default rather than the packet name?

I can do that only if you

  1. want clicking on the Packet Name column to order the rows by assigned date instead of packet name; or

  2. want a new column created for packet creation; or

  3. want to remove the ability of the user to control the sort order by clicking on column headers.

What's your pleasure?

Comment entered 2014-01-10 09:29:41 by Juthe, Robin (NIH/NCI) [E]

Could you please call me when you get a minute to discuss this one? 240-276-6592. Thanks.

Comment entered 2014-01-10 09:32:31 by Kline, Bob (NIH/NCI) [C]

I have made all the other new enhancements, ready for checking on DEV.

If you choose the first option from those given in the previous comment, I would recommend changing the column header from "PACKET NAME" to "PACKET."

Comment entered 2014-01-10 12:03:23 by Juthe, Robin (NIH/NCI) [E]

I've given some more thought to this and I think we should keep the ability to sort by packet name as well as by date. So, please add a column for the date (called ASSIGNED) and make this the default sort when the report is generated (most recent date on top). Although I know the assigned date won't always be a true reflection of when a Board member was assigned the literature if he/she were added to a packet later on, it will be accurate almost all of the time and it will make the most sense to our EICs when we share this report with them.

Please also add totals for the number of articles assigned, completed, and not completed at the bottom of the report. Thank you!

Comment entered 2014-01-10 12:14:42 by Kline, Bob (NIH/NCI) [C]

I'd be inclined to call the new column "CREATED" instead of "ASSIGNED"; not just because of the misleading nature of "ASSIGNED" in this context, but also because otherwise you'll have two columns with the same heading, but meaning two different things.

Comment entered 2014-01-10 15:41:30 by Juthe, Robin (NIH/NCI) [E]

It's fine to go with CREATED.

Comment entered 2014-01-10 15:51:57 by Kline, Bob (NIH/NCI) [C]

Good (I don't think Drupal would let us have two columns with the same name with click-on-column-header sorting enabled anyway).

I think all of the new functionality has been implemented on DEV. Please check thoroughly.

Comment entered 2014-01-17 12:48:16 by Juthe, Robin (NIH/NCI) [E]

Verified on DEV.

Comment entered 2014-01-17 13:12:05 by Kline, Bob (NIH/NCI) [C]

Promoted to QA.

Comment entered 2014-01-17 13:52:21 by Juthe, Robin (NIH/NCI) [E]

Verified on QA.

Comment entered 2014-02-25 15:45:22 by Juthe, Robin (NIH/NCI) [E]

Verified on prod.

Elapsed: 0:00:00.000274