CDR Tickets

Issue Number 5355
Summary Summary QC reports not displaying comment or markup
Created 2024-12-23 14:40:48
Issue Type Bug
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2024-12-23 19:03:26
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.484700
Description

Crystal reported today that the Patient Summaries QC reports are not displaying comment or markup on PROD. 

To Reproduce:

  1. Retrieve a patient summary with Comment and Markup in XMetal (e.g. CDR0000799746)

  2. Notice that it does have both Comment and markup (insertion and deletion)

  3. Click on the PT RLSO report icon in the Summary toolbar

  4. Scroll down to the Select Comment Types to be displayed section

  5. Sellect All Comments

  6. Click Submit

  7. You should notice that there are no comments or markup in the report

Acceptance criteria:

  1. Retrieve a patient summary with Comment and Markup in XMetal (e.g. CDR0000799746)

  2. Notice that it does have both Comment and markup (insertion and deletion)

  3. Click on the PT RLSO report icon in the Summary toolbar

  4. Scroll down to the Select Comment Types to be displayed  section

  5. Sellect All Comments

  6. Click Submit

  7. You should notice that both markup and comments are displayed in the report

Comment entered 2024-12-23 17:04:35 by Osei-Poku, William (NIH/NCI) [C]

You've probably noticed this already, but it looks like the missing comment issue also affects HP summary reports as well.

Comment entered 2024-12-23 19:03:26 by Kline, Bob (NIH/NCI) [C]

Try it out on DEV.

Comment entered 2024-12-23 21:10:36 by Osei-Poku, William (NIH/NCI) [C]

I can see both the comments and markup on DEV. Thanks!

Comment entered 2024-12-24 10:58:56 by Kline, Bob (NIH/NCI) [C]

New tests have been added to the automated test suite to ensure that if we ever have a regression in which these bugs somehow reappear, we'll catch them. All of the new tests fail on QA (where the fixes won't be applied until Sanger is deployed there). All of them pass on DEV (where the fixes are installed).

https://github.com/NCIOCPL/cdr-admin/commit/ce424a03

Comment entered 2024-12-24 12:27:21 by Osei-Poku, William (NIH/NCI) [C]

Thanks Bob! Tagging and   As it seems to me that we may want to fix this problem before Sanger since these features are needed for daily tasks.

Comment entered 2025-01-13 13:47:33 by Osei-Poku, William (NIH/NCI) [C]

This looks good on QA, but I would want Crystal to also confirm the fix before marking it as QA verified. She would be in the office tomorrow.

Comment entered 2025-01-16 11:53:57 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Elapsed: 0:00:00.001386