| Issue Number | 5088 |
|---|---|
| Summary | Fix ancient links hard-coded into filters |
| Created | 2022-01-07 15:22:29 |
| Issue Type | Improvement |
| Submitted By | Kline, Bob (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2022-01-19 21:32:10 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.308434 |
Filters CDR0000000079, CDR0000000153, and CDR0000000158 have links to pre-historic versions of jQuery. If the app scanner ever catches these it will not be happy. Upgrade these (and test). Also CDR0000797103 has a hard-coded broken link to http://cdr.dev.cancer.gov/cgi-bin/cdr/STOC_new.js. See if this is still needed and replace it with something that works if it is needed.
The three filters with the ancient link have been updated and the filter with the broken link has been updated. The link isn't used anymore. In addition, I removed some portions of the code that hasn't been in use for a couple of years. The following filters have been updated:
CDR000079.xml - Health Professional Summary Report
CDR000153.xml - Health Professional Summary Report-Bold/Underline
CD0000158.xml - Patient Summary QC Report Filter
CDR797103.xml - Cancer Information Summary for Drupal CMS
https://github.com/NCIOCPL/cdr-server/commit/e3bd48e
This is ready for review on DEV.
I have reviewed the code changes and they look good to me. Have you tested, ~volker ?
Elapsed: 0:00:00.001899