| Issue Number | 5090 |
|---|---|
| Summary | Modify publishing filters to display more information website descriptions on Cancer.gov |
| Created | 2022-01-07 15:49:42 |
| Issue Type | Improvement |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2022-02-01 11:49:20 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.308437 |
We are currently running a global in OCECDR-5037 to add website descriptions to More Information links in the Glossary Term Concept document. Please modify the publishing filters to display the correct description.
I need additional information for this ticket. It's possible that this has already been discussed in the other tickets but I can't find it there.
Should this information be part of the output for our partners?
If yes, in which format should the information be available? Providing the SourceKey attribute (it would require a DTD update) or only adding the text string
From the task description I would assume it's requested to display the value of the SourceKey attribute. However, based on the changes to XMetaL I'm assuming you want the text string displayed here as well?
1. Should this information be part of the output for our partners?2. If yes, in which format should the information be available? Providing the SourceKey attribute (it would require a DTD update) or only adding the text string
I think we should talk about this in the CDR meeting.
3. From the task description I would assume it's requested to display the value of the SourceKey attribute. However, based on the changes to XMetaL I'm assuming you want the text string displayed here as well?
The display should be the description in parenthesis as you rightly display in the element in XMetal on DEV. The SourceKey is not to be displayed.
The following filters have been modified to add the website information:
CDR315588.xml - Module: Vendor Cleanup Templates
CDR616048.xml - Vendor Filter: GlossaryTermName
https://github.com/NCIOCPL/cdr-server/commit/64a400db
This is ready for review on DEV.
Verified on DEV. Thanks!
Hi Volker,
Would it OK to add one new URL for the English terms?
https://www.cdc.gov/ This will correspond to the CDC SourceKey and the UsedFor = "EN" for the English CDR links. If that is not possible now, I can add it later in a different Jira ticket.
Isn't the CDC part of your spreadsheet? Did I forget to add that link?
I included the Spanish link and not the English link in the spreadsheet. We initially decided to exclude the English URL because it affected only two links in all of the glossary terms but I realize now that if we don't include it (for the filter change), it will not display the English descriptions, partly due to the way we are currently implementing this.
In that case we're already done. I assumed the missing link for the CDC in English on the spreadsheet was a mistake and included it in my filter anyway. 🙂
Great. I didn't realize you could see into the future 🙂. Thank you!!
It's one of my lesser known super powers. 😃
Reviewed on DEV. Please install on QA. Thanks!
The filters have been copied to QA.
With the global job completed on PROD earlier this week, the vendor output for GlossaryTerm documents now included this new SourceKey attribute. I wasn't aware that these filter changes were supposed to be copied to production before the weekly publishing job would run. Because this filter was not in place in time the publishing job failed.
I ran a diff job for Glossaries on QA to confirm that the publishing job would not fail when these filters were installed and a diff report only showed the expected changes. Once the tests on QA completed I copied the filters to STAGE and PROD and reran our weekly publishing job successfully.
These changes are now on PROD. Please verify and close this ticket.
Verified on PROD. Thanks!
Elapsed: 0:00:00.002129