| Issue Number | 5082 |
|---|---|
| Summary | Investigate use of Element LinkedKeyPoints |
| Created | 2021-12-22 19:37:22 |
| Issue Type | Task |
| Submitted By | Englisch, Volker (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2022-01-06 17:29:04 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.307480 |
There exist 4 filters creating or using the element <LinkedKeyPoints/> which is based on the existence of KeyPoints within a summary.
We need to investigate how this will be used and what needs to change for SVPC documents.
These are the filters using this element:
CDR0000335424.xml - Denormalization Filter: Summary
CDR0000339576.xml - Module: InLine Markup Formatter
CDR0000618263.xml - Denormalization Filter: Secondary Links
CDR0000699063.xml - Denormalization Filter: Summary - QD
The element <LinkedKeyPoints/> was necessary in the old days when some of the patient summaries had to be filtered using the default HP summary filter sets while the other (reformatted) patient summaries were filtered using the patient summary filter set. We don't need this distinction anymore and I have removed the creation of this element and adjusted the remaining filters to use the SummaryAudience as the sole decision point.
These filter changes are on DEV and I will need to do a little more testing of all of the affected QC reports before marking the ticket as "fixed".
The following filters have been modified on DEV:
CDR0000335424.xml - Denormalization Filter: Summary
CDR0000339576.xml - Module: InLine Markup Formatter
CDR0000618263.xml - Denormalization Filter: Secondary Links
CDR0000699063.xml - Denormalization Filter: Summary - QD
https://github.com/NCIOCPL/cdr-server/commit/2a52fd0
When testing, ensure that links to summaries from a patient summary will bring up the patient version of that linked summary.
This is just about this HP summary CDR0000276584 on DEV so I am not sure if it belongs in this ticket at all. When you run a B/U report for the summary, the Summary Ref link to the "High-Dose Vitamin C"
under the Dietary Supplements section, produces an error message. Is this something related to the changes here?
I'm afraid it is related. Let me take a look and thank you for reporting it.
The error that affected the SummaryRef links has been fixed:
CDR0000339576.xml - Module: InLine Markup Formatter
https://github.com/NCIOCPL/cdr-server/commit/14de91b
Verified on DEV. Thanks!
Verified on QA and PROD. Thanks!
Elapsed: 0:00:00.001850