CDR Tickets
| Issue Number | 5083 |
|---|---|
| Summary | Table numbers and number of citations display issues in QC reports and pub preview |
| Created | 2022-01-04 19:16:18 |
| Issue Type | Improvement |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2022-03-04 14:31:06 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.308060 |
For summaries that have modules which have been entered specifically for board members QC reports, when a QC report is generated (pub preview as well), depending on where the modules are placed within the summary, table numbers do not start to count from the first table within the summary (as Table 1). It appears to be counting tables within the module documents as well. Also, the list of citations for the summary appear to include ones from the modules when it shouldn't be, by default. Please investigate this problem and fix it so that the tables are counted as usual and the list of references also display from the summary itself and not from the modules.
Sample document on PROD. CDR0000804574 (The first table in this summary is labeled Table 4)
I have adjusted the numbering of the tables based on the inclusion/exclusion of the QC-only modules. Based on the complexity of creating the Reference section for the citations I'm expecting a change to modify citations to be way more difficult.
I haven't seen you mention the numbering for figures. Is that because HP summaries generally don't include many images? I would assume that the figure numbers behave similarly to the table numbers.
Based on the complexity of creating the Reference section for the citations I'm expecting a change to modify citations to be way more difficult.
No it isn't. I was able to apply the same set of rules for the citations that I had used for the tables. Since the filters that needed to be modified for this task were different from the ones updated for Ohm and Oersted I went ahead and made those changes on DEV.
Please take a lock on DEV.
The table numbering appears to be fine but we need to do more testing. However, there appears to be some problems with at least the B/U QC report. When you run with the default selection. (CDR0000574548)
The TOC appears to include that of the modules.
Also, in the body of the report, they are included when they shouldn't
What is the difference between CDR574548 and CDR804574? These documents appear to be identical except for the placement of the SummaryModuleLinks, yet the QC report behaves completely differently.
For both documents the numbering and display of both, the tables and the citations is correct now, isn't it?
I would be surprised if those filter changes had any effect to the display of the TOC.
You're right ~volker . We had the module elements at the top-level of the document. That is, not in any summary section and that is probably why it behaved that way. When I put them in a summary section, it appears to be behaving as expected. We will continue to test.
Verified on DEV. This is ready for QA. Thanks!
The filter changes have been copied to the STAGE server:
CDR331662.xml - Module: Citation Denormalization
CDR335418.xml - Denormalization Filter: Summary InLine Numbering
CDR723518.xml - Denormalization Filter: Summary Count Tables and Figures
Verified on STAGE. Please promote changes to PROD. Thank you!
The filters have been copied to PROD.
Please verify and close this ticket.
Verified on PROD. Thanks!
| File Name | Posted | User |
|---|---|---|
| image-2022-03-07-17-56-36-539.png | 2022-03-07 17:56:37 | Osei-Poku, William (NIH/NCI) [C] |
| image-2022-03-07-17-58-20-086.png | 2022-03-07 17:58:20 | Osei-Poku, William (NIH/NCI) [C] |
| list of citations.PNG | 2022-01-04 19:16:36 | Osei-Poku, William (NIH/NCI) [C] |
| Table 4-2.PNG | 2022-01-04 19:16:12 | Osei-Poku, William (NIH/NCI) [C] |
Elapsed: 0:00:00.000700