Issue Number | 5038 |
---|---|
Summary | Use the new EVS RESTful API for the nci_thesaurus module |
Created | 2021-10-04 14:02:20 |
Issue Type | Improvement |
Submitted By | Kline, Bob (NIH/NCI) [C] |
Assigned To | Kline, Bob (NIH/NCI) [C] |
Status | Closed |
Resolved | 2021-11-19 14:15:33 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.299924 |
All the other APIs are being deprecated. This is the sixth client
we've written for talking to the EVS, if my memory is right. This module
is used for Term
document import/update using the CDR web
admin interface.
Another incentive for switching to the latest API is that the EVS appears to be throttling the performance of the APIs they are deprecating, perhaps intentionally to provide additional incentive for clients to upgrade sooner instead of later. 🙁
I have fetched all 9,748 concepts behind the Term
documents using both the older API and the newer one, and as far as I
can tell most of the differences in the resulting XML are an artifact of
the logic which considers two strings to be the same even if they differ
in space, capitalization, or punctuation. So if the EVS gives us two
synonyms, it's the luck of the draw which one we get first and therefore
gets stored (with its term type) in the CDR document. There are a few
other differences which I assume mean that the two APIs give us
different revisions of the data. For example, C173443 (Dengue Virus
Adjuvant PV-001-DV) has the definition "An attenuated strain of dengue
virus that was originally developed as a potential preventative vaccine
for dengue fever by the US Army as Dengue Virus-1 #45AZ5, with potential
immunostimulating activity. Upon administration of dengue virus adjuvant
PV-001-DV, the virus may activate both the innate and adaptive immune
system." when we fetch from the older API, but "45AZ5, with potential
immunostimulating activity. Upon administration of dengue virus adjuvant
PV-001-DV, the virus may activate both the innate and adaptive immune
system." is what we get from the newer API. Or it may be a bug in the
new API. I believe that's the only definition which differs between the
two APIs.
Rewrite installed on CDR DEV.
This will be tested by CIAT as part of the testing for OCECDR-5093.
OCECDR-5093 has been verified on DEV. Thanks!
Verified on QA. Thanks!
Elapsed: 0:00:00.001822