| Issue Number | 5039 |
|---|---|
| Summary | DIS with markup report broken |
| Created | 2021-10-06 09:48:46 |
| Issue Type | Bug |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2022-01-24 16:03:35 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.300085 |
The DIS with Markup report appears broken as it displays only “None” even if there are DIS with markup.
Known tiers affected: PROD. Appears to work on QA.
Date first reported: 10-01-2021 1:55 PM
Date Last occurred: 10-06-2021 8:42 AM
How to Reproduce:
Go to the CDR Reports Menu
Click on the Drug Information link
Under Management Reports and Click on the Drug Summaries with Markup Report
Click Submit with all checkboxes selected or any combination of checkboxes
Examples
Sample documents with Markup on Prod.
717928 |
Ruxolitinib Phosphate |
491901 |
Cetuximab |
Excellent description, with lots of helpful information. 👍
Quick update: We're getting the same error on DEV as we're getting on PROD and I have determined that the code on both, DEV and QA is identical. This means that we're likely looking at a bug that's triggered by the data.
It looks like the report ran successfully last time in August and then started failing on Oct 1st.
There exist 2 DIS documents with a Deletion tag that's causing the problem with the report. The documents are CDR700207 and CDR717920.
Typically, the Insertion/Deletion tags are created such that the UserName, Time, and RevisionLevel attributes are populated. The DISWithMarkup.py report relies on these attributes to be populated but the Deletion tag in these documents have no attributes at all. Without this attribute value the program doesn't know which of the available attribute levels (publish, approved, proposed, rejected) the markup tag should be assigned to which is causing the report to fail.
Once these bad markup tags have been corrected the report will run again as expected.
We probably want to enhance the report not to fail in this situation and add the ticket to Ohm.
Once these bad markup tags have been corrected the report will run again as expected.
The bad tags have been cleared from the documents but the message still shows even though there are documents with markup.
It's correct that the issue with those two documents I reported has been fixed. Unfortunately, the same issue has now been introduced for yet another document: CDR804890.
Search for an empty "Insertion" tag right after the "ApprovedIndication".
You should be able to find these trouble-makers by running this query:
SELECT * FROM document WHERE doc_type = 38 AND (xml LIKE '%<Insertion/>%' or xml LIKE '%<Insertion>%')
Replace "Insertion" with "Deletion" if necessary.
The errors for this ticket had been identified as data issues. Is there still anything that needs to be done? If that's not the case we should be able to close the ticket.
~volker will review this ticket and update the LOE to reflect improvements to the software which are needed to make it more robust in the face of data errors as encountered here.
I've modified the report to include reporting documents without a valid revision level:
DISWithMarkup.py
https://github.com/NCIOCPL/cdr-admin/commit/8f4d59c
This is ready for review on DEV.
Verified on DEV. Thanks!
Verified on QA. Thanks!
| File Name | Posted | User |
|---|---|---|
| DIS with markup.PNG | 2021-10-06 09:49:41 | Osei-Poku, William (NIH/NCI) [C] |
Elapsed: 0:00:00.001308