| Issue Number | 5033 |
|---|---|
| Summary | [DIS] Drug Reference - global to populate new TemporaryLink attribute in selected DrugReference elements |
| Created | 2021-09-22 13:55:16 |
| Issue Type | Improvement |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2022-02-07 17:02:18 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.299303 |
We'll provide additional guidance about which elements should have the attribute added soon.
Any progress on this list?
Depends on the new spreadsheet in OCECDR-5031
A modified version of the spreadsheet I posted yesterday will be provided as the driver for the global change job.
How's this coming along?
ocecdr_5031-1 (MEB).xlsx Mary has taken a first pass at identifying which of the elements should have a the new temporary link attribute. The yellow highlights are ones that would definitely not be temporary and the peach colored highlights are blogposts that we might not want to mark as temporary. This is not final yet. Christina may have to review before the global can proceed.
I uploaded the updated spreadsheet from Christina.
Every link in attachment should receive the TemporaryLink attribute.
Thanks. My plan is to create a map indexed by CDR ID to sequences of
Link URL, Posted Date, and Reference Type value sets, ignoring the drug
name, link text, and description elements. For each document, I will
find each DrugReference element with matching value for one
of the document's value sets and add the TemporaryLink
attribute to those elements. I will normalize the two string values
(Link URL and Reference Type) by ignoring case, stripping leading and
trailing whitespace, and transforming sequences of whitespace characters
into single "space" characters (there really shouldn't be any spaces in
the URLs or the reference type values anyway). If you want me to relax
the matching algorithm by leaving out one or more of the three values in
the value sets, let me know. Conversely, if you want the matching logic
to be more stringent (including, for example, a check that the Link Text
value also matches), I can do that as well.
The global change has been implemented and run in test mode on DEV. A few documents didn't have matching links and one document (806069) wasn't on the lower tier at all, but that's not surprising. The ones which matched got the attribute, as far as I could tell.
https://cdr-dev.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2022-02-07_16-49-33
Test data looks good. Please run in live mode on DEV. Thanks!
Done.
Thanks! Can you please take a look at CDR0000791122 It is the first document on the spreadsheet and it looks like in the test run, it was selected for update but I don't see that it is updated in the live run. Was it checked out or I may be reviewing this in the wrong way?
As you correctly guessed, the software cannot update a locked document. In this case, you had the document checkout out yourself. 🙂
Got it. Thanks!
Verified on DEV. Thanks!
Please run global in test mode on QA. Thanks!
Verified on QA. Please run in live mode on QA. Thanks!
Done.
Verified on QA. Thanks!
Please run in test mode on PROD.
Verified. Please run in live mode on PROD.
Done.
| File Name | Posted | User |
|---|---|---|
| ocecdr_5031-1 (MEB).xlsx | 2022-02-03 13:38:45 | Osei-Poku, William (NIH/NCI) [C] |
| ocecdr_5031-2.xlsx | 2022-02-07 14:57:23 | Juthe, Robin (NIH/NCI) [E] |
Elapsed: 0:00:00.001978