CDR Tickets

The following filters have been modified to include the module's SummaryTitle element if the module gets displayed:

• CDR339576.xml - Filter title: Module: InLine Markup Formatter

• CDR712005.xml - Filter title: Denormalization Filter: Summary Module

Once I get the OK for the display of these changes I will include the module's SummaryTitle in the TOC.

Hi Volker ~volker I have a question about displaying the title in the TOC as mentioned above. Looking at the comments from OCECDR-4968 , it looks like Robin had already determined that there is no need to include the title in the TOC. Is that different from the TOC you're mentioning here?

" Robin already said we won't need to make this module SummarySection linkable and there is no need to link to it from its TOC entry, for instance."

I have another question as I thought this change was only for QC reports but I am not completely sure. On DEV, when you run PP for the Genetics of Renal Cell Carcinoma summary (CDR0000574548). The titles of the modules are included in the body of the summary. Please see attached screenshot. 

I thought this change was only for QC reports but I am not completely sure.

Yes, ~oseipokuw, you are correct.  I did not suppress the extra elements when the filter set was used for the PP report.  I've made those adjustments and the PP report doesn't display the titles anymore.

I had to make additional changes to the two filters:

• CDR339576.xml - Filter title: Module: InLine Markup Formatter
  https://github.com/NCIOCPL/cdr-server/commit/0691785

• CDR712005.xml - Filter title: Denormalization Filter: Summary Module
  https://github.com/NCIOCPL/cdr-server/commit/0691785

I have moved this ticket to the Oersted as we have talked about including it in the next release. Development is done and it only needed thorough testing.

Based on our discussion on Thursday it sounds you all would like this ticket to go to production sooner rather than later.  The difficulty about moving tickets around is handling this change in Github.  Therefore, rather than extracting the change out of Ohm and incorporating it back into Oersted I'd prefer to move the change to PROD individually as a hot-fix.  We'll only need help from CBIIT for a single Python script.  All other changes are filter related and we can do these ourselves.

Therefore, is everyone OK to move these changes to production as a hot-fix and, ~oseipokuw, have you already tested these changes on DEV?

Hi Volker ~volker It is OK to hot-fix these tickets instead of including them in Oersted. So, I am moving them back into the Ohm for now, while we test and report any additional issues we find.

For pub preview, the content of the modules are now displaying. The content of the modules should not be displaying in pub preview because the summary module links are in the summary for QC report purposes only. They should be ignored by the pub preview filters since they have been marked as "qc-only".

Please see CDR0000574548 on DEV as an example.

Verified on QA. Thanks!

The filters have been copied to STAGE and PROD.  

The web interface to select the new options will be copied on Monday.

All changes have been copied to PROD.  Please verify and close this ticket.

Looks good on PROD. Thanks!