CDR Tickets

~oseipokuw, is it intentional that the module is listed as a treatment summary but the board is the genetics board?

I'm looking at "Von Hippel-Landau Disease".

No. That must be an error. They should be typed as Genetics. Is that the cause of the error message?

~volker  That appears to be the problem. Changing the Type to Genetics worked. Thanks for catching this.

What happened is that the filter is looking for the LOE Summary document that's linked to the specified board.   If the specific summary were a Spanish document, the filter is looking for the TranslationOf element in order to identify the English board information because we don't have Spanish boards.  This check is only done for summary types with Spanish translations.  Since the document was marked as a Treatment summary, the system expected to find a Spanish LOE Summary but that does not exist for the Genetics board and that's the reason why the QC report failed.

I have added a test to display a more meaningful error message if we come across this situation again which hopefully will help us find the issue more quickly. I will therefore reopen this ticket to push the changes to PROD.

The following filter has been modified:

• CDR335424.xml - Denormalization Filter: Summary
  https://github.com/NCIOCPL/cdr-server/commit/541dcc1

This is ready for testing on DEV.

Verified on DEV. The new message is better. Thanks!

An error has occurred

filtering error: Spanish LOE translation missing for this summary type and board!

I copied the changes to QA and ran summary QC and vendor output jobs.  There were no differences between the "before" and "after" output.

Please go ahead, ~oseipokuw, and double-check on QA before I'll move the changes to STAGE and PROD.

Verified on QA. Please copy to PROD. Thanks!

The filter changes have been copied to PROD.

I am unable to confirm that this is working on PROD. Using this test document on PROD - CDR0000668479 and changing the board and summary type information, I get the same error as before. 

I checked the filter making sure the changes did make it to PROD.  This appears to be the same error message as before but it's triggered by something else.  I will take a look after our meeting.

Originally, the filter checked if a version of the LOE document existed which did not.  However, I should have checked if a publishable version of the LOE document exists.  I have now modified the internal SQL query and in addition improved the error message displayed slightly.

In addition, I've modified the Quick&Dirty QC report to ignore the error and display a hint of why the QC report is failing.  The required three additional filters to be modified:

• CDR0000335424.xml - Filter title: Denormalization Filter: Summary

• CDR0000699063.xml - Filter title: Denormalization Filter: Summary - QD

• CDR0000409593.xml - Filter title: Copy XML for Summary Report

• CDR0000434822.xml - Filter title: Module: QC Filter Templates - Summary
  https://github.com/NCIOCPL/cdr-server/commit/5898083

Please use CDR62902 to see the effect of the changes for the QD version of the report. This is ready for review on DEV.

Verified on DEV. Thanks!

The filter changes have been copied to QA.

Please review on QA.

All diff reports for the Summary and DIS QC reports came out without any differences.

~oseipokuw, please let me know when you are ready to have these filter changes copied to PROD.

Please proceed to copy it to PROD. Thanks!

The filter changes have been copied to STAGE and PROD.  Please confirm and close this issue.

Verified on PROD. Thanks!