| Issue Number | 4940 |
|---|---|
| Summary | Summary Displays Proposed References with Approved Mark-up |
| Created | 2021-02-11 12:31:17 |
| Issue Type | Bug |
| Submitted By | Englisch, Volker (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2021-03-19 18:19:38 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.284727 |
Victoria Shields found the following:
I Noticed something odd in a summary. I ran the redline/strikeout report for the CWD for CDR 792723 (Adult Acute Myeloid Leukemia TEMP). All of the changes in there are in proposed markup, so all of the changes should have shown as GREEN in the report but there are a couple of new refs that are showing up as RED within the text (where the numbers are listed). They were already in the summary (cited in the paragraph just above) so they are not new and therefore not highlighted in the references list.
They are in the Treatment of Refractory or Recurrent Adult AML section as refs 11 and 12.
Adding ~vshields as a watcher and adding a screenshot of the display.
It appears that these rascal citations are inside a Para element that's a child of a ListItem. I will try to recreate the issue and investigate on DEV.
It appears that these rascal citations are inside a Para element that's a child of a ListItem.
The document I was looking at tricked me. There was a proposed deletion inside a ListItem that displayed correctly while the proposed insertion inside the Para did not display correctly. However, this is an issue for all proposed insertions as my sample (attached) shows.
It's always "fun" to track down QC markup issues - for some level of fun. The following filter has been modified to display proposed citation links in proposed markup:
CDR339576.xml - Module: InLine Markup Formatter
https://github.com/NCIOCPL/cdr-server/commit/7823173
I will have to run diff reports on QA because this filter is used in many places but the changes are ready for review on DEV.
The diff reports did not show any unexpected changes.
This is ready for testing on DEV.
Since you reported this issue, ~vshields, do you want to check this out?
The references are no longer showing as green, so it looks like you showed those scallywag citations who's boss! Thank you!
I'm crossing my fingers that you meant to say: "... are no longer showing in red ..." because they are now green. We do want proposed citations to display in green.
Ack! Yes, they are no longer RED, they are GREEN! Thanks!
The filter changes have been copied to PROD and STAGE.
Please verify on PROD and close this ticket.
Victoria reviewed the changes on PROD and confirmed they are looking good.
Closing ticket.
| File Name | Posted | User |
|---|---|---|
| Screen Shot 2021-02-11 at 11.43.32 AM.png | 2021-02-11 12:52:42 | Englisch, Volker (NIH/NCI) [C] |
| Screen Shot 2021-02-11 at 6.13.44 PM.png | 2021-02-11 18:15:00 | Englisch, Volker (NIH/NCI) [C] |
Elapsed: 0:00:00.001529