CDR Tickets

Issue Number 4877
Summary [DIS] DIS by Drug Type Report
Created 2020-09-09 16:39:22
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2021-05-20 17:09:30
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.274437
Description

This is a new report that will be generated to view all DIS for drugs of a certain "type", using the data from the new Drug Type element. Requirements attached.

Comment entered 2021-03-24 12:04:47 by Osei-Poku, William (NIH/NCI) [C]

The requirements document is attached. Thanks!

Comment entered 2021-03-24 13:31:29 by Kline, Bob (NIH/NCI) [C]

Adding  as a watcher.

Please provide the business case for the custom code which would be required in order to give the user the option to switch between checkboxes and a dropdown list at runtime for the Drug Types field on the report request form, .

Comment entered 2021-03-24 15:20:27 by Osei-Poku, William (NIH/NCI) [C]

As I mentioned in the requirements document either of the two options should be fine.


           (Either a list of all drug types with checkboxes or a drop-down menu of all drug types. Having both options would be great. If not, having a list of the drug types as a drop-down menu should be good. We also want the ability to select one or more drug types to run the report )

When we talked about this, the preference was for a list of drug types with checkboxes. However, knowing that the list could grow over time to fill a substantial part of the interface, we also suggested having a drop down menu as well, if possible.

At this point, having a list of checkboxes should meet our needs for the data we currently have.

Comment entered 2021-03-31 16:15:22 by Kline, Bob (NIH/NCI) [C]
  1. Do you want the set of checkboxes to reflect the values actually used in the documents? Or do you want the report to parse the schema to get the list of all possible drug types? (I assume you don't want the software to use a hard-coded list of values.)

  2. For DIS documents with more than one instance of the DrugType field, do you want a separate row in the report for each instance? If not, how should the multiple values be presented? And shouldn't the column header by "Drug Types" if we're not going to show a separate row for each drug type?

  3. Since the requirements don't say, I'm going to sort the drugs by drug title.

Comment entered 2021-04-06 13:46:35 by Osei-Poku, William (NIH/NCI) [C]

1. Do you want the set of checkboxes to reflect the values actually used in the documents? Or do you want the report to parse the schema to get the list of all possible drug types? (I assume you don't want the software to use a hard-coded list of values.)

The second option is preferred with a list of all possible drug types in the schema.

2. For DIS documents with more than one instance of the DrugType field, do you want a separate row in the report for each instance? If not, how should the multiple values be presented? And shouldn't the column header by "Drug Types" if we're not going to show a separate row for each drug type?

Yes, a separate row for each instance is preferred. "Drug Types" header is also fine.

3. Since the requirements don't say, I'm going to sort the drugs by drug title.

The sort order is fine as well. Thanks!

Comment entered 2021-04-06 17:31:32 by Kline, Bob (NIH/NCI) [C]

Implemented on CDR DEV.

 

Just so tracking the requests can come up with more accurate numbers for the types of requests, I would suggest that a request for a brand new report would be a "New Feature" and a modification of an existing report (for example, OCECDR-4967) would be an "Improvement" (the existing tickets have the types backwards). Not something that necessarily has to be corrected for the existing tickets, just something to bear in mind for future requests. 😉

Comment entered 2021-04-27 17:16:47 by Osei-Poku, William (NIH/NCI) [C]

Could you place the report on the DIS menu. It is looks like it is missing from under "Other Reports".

Comment entered 2021-04-28 08:07:35 by Kline, Bob (NIH/NCI) [C]

Added to menu on DEV.

Comment entered 2021-04-28 11:23:50 by Osei-Poku, William (NIH/NCI) [C]

Thanks!

Please make "All" the default selection for the Drug Types.  I am able to select "All", and at the same time select other drug types. Could you modify it so that when I select other drug types, I won't be able to select "All" at the same time? It could get confusing with those selections.   Also, please make "Web Page" the default selection for the display option.

Comment entered 2021-04-29 14:22:36 by Kline, Bob (NIH/NCI) [C]

William will check to ensure that the report uses "All" as the controlling value for drug types if that selection is made in addition to other specific drug types.

Comment entered 2021-04-29 15:58:57 by Osei-Poku, William (NIH/NCI) [C]

I was able to confirm that "All" works as expected. Also, the default display option is the Web Page.

Comment entered 2021-05-20 16:52:01 by Juthe, Robin (NIH/NCI) [E]

The Resolution of this ticket is "Won't Fix" - is that a mistake?

Comment entered 2021-05-20 17:10:52 by Osei-Poku, William (NIH/NCI) [C]

I have corrected it. Must have been my error when moving the ticket to DEV Verified. Thanks!

Comment entered 2021-05-20 17:30:55 by Juthe, Robin (NIH/NCI) [E]

Ok thanks! Sorry to be nitpicky - just trying to see which ones will need QA testing and which ones won't 🙂. I'm planning to loop Christina in to take a look at this one.

Comment entered 2021-06-04 11:21:12 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA. Thanks!

Comment entered 2021-06-17 09:52:20 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Attachments
File Name Posted User
DIS by Drug Type Report.docx 2021-02-17 13:59:25 Osei-Poku, William (NIH/NCI) [C]

Elapsed: 0:00:00.001390