Issue Number | 4681 |
---|---|
Summary | [Glossary] Fix Glossifier loader |
Created | 2019-10-23 16:05:50 |
Issue Type | Bug |
Submitted By | Osei-Poku, William (NIH/NCI) [C] |
Assigned To | Kline, Bob (NIH/NCI) [C] |
Status | Closed |
Resolved | 2020-04-13 12:01:04 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.251446 |
Adding offline conversation with Bob below:
From: Bob Kline <bkline@rksystems.com>
Sent: Wednesday, October 23, 2019 3:35 PM
To: Osei-Poku, William <William.Osei-Poku@icf.com>
Subject: Re: FW: DUPLICATE GLOSSARY TERM NAME MAPPINGS ON
NCIWS-P193-V
Thanks, that's helpful. I found a bug in the loader, which incorrectly caches the information from the external map table until the scheduler service is restarted. Please add a ticket to Leibniz to get this fixed.
Thanks,
Bob
On Wed, Oct 23, 2019 at 2:10 PM Osei-Poku, William
<William.Osei-Poku@icf.com> wrote:
All 4 terms were changed.
We added a period at the end of each term.
The changes were made between 7:20 am and 12:00 PM yesterday.
The hot-fixes were made 11:20 AM and 12:02 PM yesterday.
All hot-fixes were successful.
Thanks,
William
From: Bob Kline <bkline@rksystems.com>
Sent: Wednesday, October 23, 2019 1:09 PM
To: Osei-Poku, William <William.Osei-Poku@icf.com>
Subject: Re: FW: DUPLICATE GLOSSARY TERM NAME MAPPINGS ON
NCIWS-P193-V
Please provide more information.
• which terms were changed? all four, or just one of each pair?
• what were the changes?
• what time was each change made?
• which documents were hot-fixed when and with which changes?
• were there any errors for the hot fixes?
Without this information, I can't tell what was on the web site when the
scheduled glossifier job ran.
Thanks,
Bob
On Wed, Oct 23, 2019 at 12:23 PM Osei-Poku, William
<William.Osei-Poku@icf.com> wrote:
Hi Bob,
We fixed the duplicate in the mapping table, made minor changes to the
terms, hot-fixed them (and reverted the changes and hot-fixed again) in
an attempt to stop the emails. But the email still came out this
morning. Is there any other way to avoid getting the emails even after
the duplicate problem has been fixed ?
Thanks,
William
------Original Message
From: cdr@nciws-p193-v.nci.nih.gov
<cdr@nciws-p193-v.nci.nih.gov>
Sent: Tuesday, October 22, 2019 11:01 PM
To: bkline@rksystems.com; Kuhlmann, Amy <Amy.Kuhlmann@icf.com>;
mbeckwit@mail.nih.gov; Osei-Poku, William
<William.Osei-Poku@icf.com>; Saucedo, Linda I.
<LindaI.Saucedo@icf.com>; Jamison, Ann
<Ann.Jamison@icf.com>; Yousufzai, Maryam
<Maryam.Yousufzai@icf.com>; Lansberry, Isabel
<Isabel.Lansberry@icf.com>
Subject: DUPLICATE GLOSSARY TERM NAME MAPPINGS ON NCIWS-P193-V
The following 2 sets of duplicate glossary mappings were found in the CDR on NCIWS-P193-V. Mappings for any phrase + language + dictionary must be unique. Please correct the data so that this requirement is met. You may need to look at the External Map Table for Glossary Terms to find some of the mappings.
ESFENOIDES (language='es' dictionary=u'Cancer.gov')
CDR0000557105
CDR0000798606
GENÉTICA (language='es' dictionary=u'Cancer.gov')
CDR0000444994
CDR0000046391
Fix installed on DEV. Two possible methods of testing.
Add duplicate to external mapping table; receive duplication notification; the next day fix the duplicate in the external mapping table; confirm that no duplicate notification goes out that night.
Add mapping to external mapping table; verify that it works in the Drupal-based glossifier (https://www-cms-dev.cancer.gov) the following day.
We went with option 1 above and added some duplicate terms - 799637 45760 46290 but they are not included in the notifications. I suspect it is because we are not running any publishing jobs on DEV at the moment. Do you think hot-fixing these terms will work or we have to wait until you run a publishing job on DEV?
CDR799637 is not in the pub_proc_cg
table, but the other
two documents are. If those two have duplicates and they were in the
table last night, they should have been included in the notifications.
What are the particulars of the duplicates?
Verified on DEV. Thanks!
Verified on QA. Thanks!
Still testing, ~oseipokuw?
We have not been able to test this on PROD yet . I am closing the ticket now and will reopen if necessary.
Elapsed: 0:00:00.001180