CDR Tickets

Issue Number 4518
Summary [ORG] Schema change to remove CIPS Contact Person and global change
Created 2018-09-13 15:51:49
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2019-04-22 14:33:10
Resolution Won't Fix
Path /home/bkline/backups/jira/ocecdr/issue.233054
Description

As discussed in today's review meeting, please modify the Org. schema to remove the CIPS Contact Person element and also run a global to remove the element from the affected Org. documents.

Comment entered 2018-09-18 13:38:48 by Osei-Poku, William (NIH/NCI) [C]

Other elements causing the QC report not to run are:

1. ResearchBaseFor (child of OrganizationAffiliations) Example 35883 (29310 U CCOP - pstate Carolina has been deleted but still remains linked to 35883)

2. ParentOrganization - Example 34983 (29106 has been deleted )

Comment entered 2018-10-16 10:53:23 by Kline, Bob (NIH/NCI) [C]

Script to remove CIPSContactPerson elements is running on DEV in test mode. Test results can be review at https://cdr-dev.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2018-10-16_10-48-36.

Comment entered 2018-10-18 11:36:54 by Osei-Poku, William (NIH/NCI) [C]

Verified. Please run in live mode on DEV.

Comment entered 2018-10-18 13:24:29 by Kline, Bob (NIH/NCI) [C]

OK. Are you planning to put in a separate ticket to do something about the two elements you mentioned in your previous comment, or was that just an informational comment?

Comment entered 2018-10-22 14:48:12 by Kline, Bob (NIH/NCI) [C]

Just a reminder about the question in that last comment, .

Comment entered 2018-10-22 19:58:54 by Osei-Poku, William (NIH/NCI) [C]

I just created the ticket to take care of the two elements - OCECDR-4538.

Comment entered 2019-04-17 13:13:52 by Englisch, Volker (NIH/NCI) [C]

, this is the ticket that goes along with the global change for the org documents.  I'm assuming this ticket addresses the schema changes only.

Since William is out would you happen to know if the removed elements from OCECDR-4538 are supposed to be removed from the schema or made optional? Most of the elements are optional already.

Comment entered 2019-04-17 13:21:49 by Kline, Bob (NIH/NCI) [C]

In recent similar cases, the users have opted to forego the more rigorous schema control over the structure of new document versions in order to make it possible to view older versions of the documents in XMetaL's standard or tags-on view mode, rather than use the admin interface to look at those older versions.

Comment entered 2019-04-17 17:37:40 by Englisch, Volker (NIH/NCI) [C]

That's what I thought but all of the elements are already optional.

I guess we'll have to wait until William is back with this one.

Comment entered 2019-04-22 10:11:59 by Osei-Poku, William (NIH/NCI) [C]

Thanks, Bob! Yes, we always prefer to be able to view previous versions of documents in XMetal without the documents being invalid. 

Volker, since the elements are optional, I think we can skip the schema change and run a global to remove the data and elements from the affected documents. As long as the links are not in the org document, it shouldn't fail.

Comment entered 2019-04-22 14:33:10 by Englisch, Volker (NIH/NCI) [C]

All elements removed by the global change are optional.  Schema changes aren't necessary.

Elapsed: 0:00:00.000343