| Issue Number | 4496 |
|---|---|
| Summary | [DIS]Global change to add links to Daily Med in DIS that don't have them. |
| Created | 2018-07-05 14:07:26 |
| Issue Type | Improvement |
| Submitted By | Beckwith, Margaret (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2018-08-07 13:40:08 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.228810 |
We need to add links to Daily Med from DIS that don't have them. This link goes in the DrugReferenceLink within the DrugReference block with the DrugReferenceType of FDA.
I am attaching a spreadsheet with the CDR IDs and links and link language.
Implemented and tested on DEV. I assumed that the required
section attribute of the DrugReference wrapper
was supposed to have the value "FDA" (let me know if that's not right).
Test run output available for review at:
https://cdr-dev.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2018-07-05_14-48-30
Yes, that is correct. Sorry, I forgot we had added those attributes.
William, could you ask Mary to take a look at the Dif report? Christina and I will also review it, but probably good to have another set of eyes.
This may be a silly question, but I happened to notice that in the Dif report, whenever there is an ampersand in the original url from the spreadsheet, it is replaced by & in the url in the dif. Does that matter? Example 500271 epirubicin hydrochloride
I believe JIRA is subverting your attempt to show me that
& is being replaced by & (by
itself replacing your & with &).
It is correct that the ampersand is stored in the XML document as the
entity &.
JIRA tip: in order to get JIRA to show & in a
comment the way you expect it to, you have to actually enter
& (I'm not going to explain how I had to enter
this sentence or we might get into an infinite loop :-)).
The other way to get the entity to display correctly is to wrap the
XML fragment inside an xml code block as documented on the pages you get
to by clicking the ❓ icon below the comment box; for example:
{code:xml}
<characters name="mutt & jeff"/>
Wow. Thanks for the explanation and the tip. Hopefully I won't have to report this again! And we definitely don't want to get into an infinite loop--very difficult to escape from those🙂 But, given that explanation, so far all of the Difs I have looked at look fine. Christina and Mary are both checking these as well.
All of the ones I checked have looked fine, too. Thanks.
... given that explanation, so far all of the Difs I have looked at look fine. Christina and Mary are both checking these as well.
The proof of the pudding will be running the job on DEV in live mode, after which you will be able to see the encoded ampersands appearing in XMetaL as ampersands (even though they're encoded as the entity in the document).
All of the ones Mary Barnstead checked look good. Thanks.
Next steps, ~mbeckwit? Ready for live mode on DEV?
Yes.
Live run has completed on DEV. You should be able to see the changes in XMetaL on that tier now.
Great! We'll check them out. Thanks.
Could you please update the Date Last Modified with the current date? Both Christina and Mary have reviewed some of the documents and they all looked good with the exception of the DLM not updated.
OK. It's unfortunate that we didn't get that requirement up front, or at least before we ran the job in live mode on DEV. We'll have to do subsequent testing on QA. Let me know if you want the next run in test mode or live mode. Be sure we have all the requirements before we proceed further, lest we run out of tiers on which to test. :-)
From what I understand, the missing DLM is the only requirement. So, if there is no objection we can proceed to run in test mode on QA with the new requirement.
That's fine with me also.
Test run completed successfully on QA with the new requirement implemented. You'll want to review the output extra carefully, because the job's script was written against the newly rewritten global change harness, and since Ising is not yet deployed to QA, I had to do some manual patching to make the script work.
https://cdr-qa.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2018-07-11_13-33-33
Please run in live mode on QA. We've reviewed the test run and didn't see any issues with it.
Live run on QA completed successfully. Please review.
I reviewed 5 random DIS on QA and thought they all looked fine. I ran in PubPreview and checked links to DailyMed, which were all working. We'll wait for CIAT and Christina to sign off, but from my perspective it looks good.
We have also reviewed these and they all look good. So, we are ready for a test run on PROD.
https://cdr-dev.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2018-07-23_08-45-28
The test results are on DEV but the documents are from PROD.
They look good. Please proceed to run in live mode on PROD.
Job has been run in live mode on PROD.
We reviewed this on PROD and everything looks good. Thanks!
| File Name | Posted | User |
|---|---|---|
| DISs without DailyMed links FINAL to MB 7-4-18.xlsx | 2018-07-05 14:06:11 | Beckwith, Margaret (NIH/NCI) [E] |
Elapsed: 0:00:00.001618