CDR Tickets

Issue Number 4500
Summary CDRClient Process Fails to Remove Template Files
Created 2018-07-17 13:16:47
Issue Type Improvement
Submitted By Englisch, Volker (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2018-09-13 12:15:59
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.229413
Description

It appears that the CdrClient process is properly updating modified files and adding new files but it's not removing outdated files.
I've inspected the manifest file and can confirm that the correct list of documents are listed. The ones we'd like to have deleted like InScropeProtocols, GlossaryTerm, etc. aren't included. I've manually removed the templates from the XMetaL templates directory which will remove them from the list of templates displayed but once the user connects to another server, these templates are restored again and will not be deleted by the CdrClient.
I will take a look at the software but we may need to wait for Kline, Bob (NIH/NCI) [C] to update the code.

Comment entered 2018-07-24 09:06:43 by Kline, Bob (NIH/NCI) [C]

I had been working on this ticket under the assumption that the build or deployment process failed to remove the retired files from the server. However, now I'm wondering if that was true. When you said you removed the unwanted templates from directory, were you talking about the CDR QA server, or were you talking about an individual user's client machine?

Comment entered 2018-07-24 11:49:28 by Kline, Bob (NIH/NCI) [C]

I have identified the bug in the loader which is causing this behavior. It's on the client (in the loader) not in the build or deploy scripts on the server for new releases. The server has the right files but the instructions for deleting the retired files are not being followed properly by the loader on the user's machine. Unfortunately, even if we include the fix for this bug in Ising, it will not go into effect soon enough to remove the old templates from the users' machines. Future file deletions will work correctly, but the templates being removed by Ising will have to be deleted by hand. We can provide you a script which you can use to do this on the users' computers, . Would you like us to do that?

This approach is safer than trying to create a custom build of the loader which includes just this bug fix but nothing else introduced by Ising and sneaking that onto the upper tiers with a separate patch before deploying Ising.

Comment entered 2018-07-24 12:26:11 by Osei-Poku, William (NIH/NCI) [C]

Sure. Providing the script should be fine.

Comment entered 2018-07-24 13:40:53 by Kline, Bob (NIH/NCI) [C]

Script has been attached. You can test it now when logged into DEV or QA, though the files will come back next time you connect to STAGE or PROD. For most users, you would only run this after they have logged into PROD after Ising has been deployed.

Comment entered 2018-07-24 14:36:38 by Osei-Poku, William (NIH/NCI) [C]

It works on QA but not DEV. On QA, I get this message once after entering my password.

When this message appears and I click okay, I am able to successfully log into QA and I could confirm that the files were gone.

On DEV, I get the message above two times and a third message (below)

and yet, I am not able to log in.

Comment entered 2018-07-24 14:58:23 by Kline, Bob (NIH/NCI) [C]

That was an unrelated problem. Please try DEV again.

Comment entered 2018-07-24 15:02:44 by Osei-Poku, William (NIH/NCI) [C]

It worked on DEV. Thanks!

Comment entered 2018-09-13 12:15:49 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Attachments
File Name Posted User
ising-cleanup.cmd 2018-07-24 13:39:01 Kline, Bob (NIH/NCI) [C]
Loaderscreenshot1.png 2018-07-24 14:34:10 Osei-Poku, William (NIH/NCI) [C]
Loaderscreenshot2.png 2018-07-24 14:35:33 Osei-Poku, William (NIH/NCI) [C]

Elapsed: 0:00:00.001695