CDR Tickets

~oseipokuw: I have done some analysis of the existing DerivedFrom blocks. I'm trying to figure out what to do with the sibling Comment elements I'm finding alongside the FromObject elements. My original thought was to make the new TranslationOf a top-level element, as we did for the Summary documents, replacing the DerivedFrom element. However, because many (most? all?) of the DerivedFrom elements also have Comment child elements, those comments would be lost if I did that. Looking at the comments themselves, I can see that many (most?) of them are not comments about the English image/Spanish image relationship of the Media documents, but are instead comments describing the evolution of the image as it goes through various modifications/processing stages. Why aren't these comments placed at the top level, as is done everywhere else (or, possibly more appropriate in some of the cases, inside ProcessingStatus elements)?

I have attached an XML document which collects all of the DerivedFrom blocks found in Spanish Media documents which have a FromCdrMedia element so you can see what the comments are actually saying. I'll hold off on further work for this task (and the comparable schema task, as well as the corresponding modificatons to the translation queue management software).

Thanks.

I have reviewed some of the comments and I agree that most of them should have gone inside the processing status blocks. Now, I am thinking that instead of replacing the existing elements, we should rather leave them there and create the new set of elements. We definitely want to keep the comments and possibly copy them into one of the processing status blocks or into new ones. However, I would want others to weigh in on this before we do that. I think the safest thing to do now is to create the new elements and leave the existing DerivedFrom block in the documents.

OK, so I'll go ahead and duplicate the link in the new element, and CIAT can go through and manually move the comments where the belong (deleting DerivedFrom blocks as appropriate). Just so you have an idea of the scope of that task, there are 373 documents in this situation (identified in the attachment you reviewed).

Global change implemented and run in test mode on DEV:

https://cdr-dev.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2018-07-03_16-18-38

I modified the global change to pick up the denormalized title of the linked English document. I would have been picked up anyway by subsequent processing, but I figured it would be less confusing as you're reviewing the results of the global change tests if you could see the denormalization results.

https://cdr-dev.cancer.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2018-07-05_09-28-25

The job is still running, but there's already plenty of results to review.

In some cases, the diff report indicates that comments were removed and re-added to the document but other documents do not show that these changes. Should we be reviewing these as well ?

It looks like the ones without the comment activity in the diff report do not have comments in the Processing status block. This makes more sense now.

Verified on DEV. Please run in live mode on DEV.

Live run completed on DEV. Please review.

Verified on DEV. Thanks!

Verified on QA. Thanks!

Verified on PROD. Thanks!