CDR Tickets

Issue Number 4339
Summary [Summaries] Modify PublishPreview report to pick up only publishable versions of images
Created 2017-11-16 16:47:41
Issue Type New Feature
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2018-03-30 13:24:39
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.217149
Description

Please modify the vendor filters so that only images in media docs that have publishable versions are picked up for publishing in summaries documents. Currently, the images picked up for publishing in summaries include ones that are in the CWD and have not been made publishable.

Comment entered 2017-11-16 17:03:57 by Englisch, Volker (NIH/NCI) [C]

, there isn't a problem with the Vendor filters. The problem is with the PublishPreview report.

Please be aware that with this change you will not be able to preview brand new images using the PP report if those have not been made publishable.

Comment entered 2017-11-16 17:38:52 by Osei-Poku, William (NIH/NCI) [C]

Let's wait to discuss this further before making any changes as I am not sure I know all the implications of this.

Comment entered 2017-11-30 14:13:03 by Juthe, Robin (NIH/NCI) [E]

We should check to see whether the QC reports use the same filter set as PP. If they do, we will need to run this change past the other Board managers.

Comment entered 2017-12-06 12:32:21 by Juthe, Robin (NIH/NCI) [E]

We discussed this with the other Board managers and Diana today and we agree with the proposed change to display publishable images/captions only in Pub Preview. However, we would like to see non-publishable changes that are in progress in the RLSO and B/U QC reports. I think the QC reports are currently displaying the non-publishable images but the publishable captions so this likely requires a change.

Comment entered 2018-02-16 07:39:19 by Kline, Bob (NIH/NCI) [C]

: please assign story points for this ticket.

Comment entered 2018-03-28 19:32:34 by Englisch, Volker (NIH/NCI) [C]

We should check to see whether the QC reports use the same filter set as PP.

We need to discuss this change a little more since both, the PublishPreview and the QC reports are using the same denormalization filters. We will need to discuss if and how we're able to display publishable versions of the images while still displaying only the non-publishable version as part of the QC report.

Comment entered 2018-03-29 13:47:38 by Juthe, Robin (NIH/NCI) [E]

I understand that Bob has given you the technical information about whether the media themselves are retrievable by version. Is there anything else you need from us to proceed? Thanks.

Comment entered 2018-03-30 12:44:49 by Englisch, Volker (NIH/NCI) [C]

Nope, it's all on me now.
Thanks for asking, Robin.

Comment entered 2018-03-30 13:03:36 by Englisch, Volker (NIH/NCI) [C]

I've modified the program which selects the images to be displayed:

  • GetCdrImage.py

However, I am not certain if the approach chosen will be working in all cases. Therefore additional changes may be necessary. In the future, we'll be able to select the last publishable version of an image by passing the CDR-ID along with a parameter pp = Y/N.

I've added an non-publishable image used in the summary Thymoma and Thymic Carcinoma... (CDR269321) for testing on DEV.

Comment entered 2018-03-30 13:24:31 by Englisch, Volker (NIH/NCI) [C]

The following program has been saved on github:

Comment entered 2018-04-11 14:49:34 by Osei-Poku, William (NIH/NCI) [C]

Verified on QA. Thanks!

Comment entered 2018-05-31 12:41:28 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD.

Elapsed: 0:00:00.001433